-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ports - Angela #13
base: master
Are you sure you want to change the base?
Ports - Angela #13
Changes from all commits
a90369b
bccc77f
7920e1c
c3e5ca8
50a0e54
db3bcbe
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,3 +15,7 @@ | |
padding-top: 7rem; | ||
background-color: #E6ECF0; | ||
} | ||
|
||
ul { | ||
list-style: none; | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,9 +2,14 @@ import React from 'react'; | |
import './Timeline.css'; | ||
import TimelineEvent from './TimelineEvent'; | ||
|
||
const Timeline = () => { | ||
// Fill in your code here | ||
return; | ||
|
||
const Timeline = (props) => { | ||
|
||
return( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Very clean and easy to see the flow of the data from timelineData.json |
||
<div className='timeline'> | ||
<TimelineEvent status={props.event.status} person={props.event.person} timeStamp={props.event.timeStamp}/> | ||
</div> | ||
); | ||
} | ||
|
||
export default Timeline; |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,9 +2,17 @@ import React from 'react'; | |
import './TimelineEvent.css'; | ||
import Timestamp from './Timestamp'; | ||
|
||
const TimelineEvent = () => { | ||
// Fill in your code here | ||
return; | ||
} | ||
const TimelineEvent = (props) => { | ||
|
||
const time = <Timestamp time={ props.timeStamp} /> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good idea to make use of the Timestamp component and saving its return value in a variable |
||
|
||
return( | ||
<section className='timeline-event'> | ||
<p className='event-person'>{props.person}</p> | ||
<p className='event-status'>{props.status}</p> | ||
<p className='event-time'>{time}</p> | ||
</section> | ||
); | ||
}; | ||
|
||
export default TimelineEvent; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great idea to just map in the App component!