Sockets - Riyo

[RPerry]

TREK

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
What does it mean for code to be asynchronous?	The user can still interact with a web page while waiting for an API response.
Describe a piece of your code that executes asynchronously. How did this affect the way you structured it?	When a trip is clicked, a get request is sent but the page does not refresh and the user can continue to use the page as the trip details load.
What kind of errors might the API give you? How did you choose to handle them?	The API might return a 404 error. I returned the status to the user.
Suppose you needed to routinely find a specific Trip in the list by it's ID field. Would it be advantageous to keep the list in order by the id field? Explain why or why not.	You would be able to pass the ID into the get request regardless of the list order so it wouldn't be advantageous.

[CheezItMan]

TREK

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	Good number of commits. It's better to provide descriptive commit messages rather than use wave numbers.
Comprehension questions	Check, Asynchronous code is code which could run in any order. You cannot predict when an API callback will occur, or when an event handler will run.
Functionality
Click a button to load and view a list of trips	Check
Clicking the "load" button twice does not cause each trip to display twice	Check
Click a trip to load and view trip details	Check
Clicking a different trip loads different details	Check
Open network tab, then fill out a form to reserve a spot	Check
Submitting the form only sends one POST request	DOH! See my notes, you didn't finish wave 3.
Errors are reported to the user	NOPE, you have most of the code in place, but a bug in your error messaging. See my notes.
Site is clearly laid out and easy to navigate	Minimal styling
Under the Hood
Callback functions are not nested more than 2 levels deep	Check
Callback functions are given descriptive names	Check
Code is generally well-organized and easy to read	Check
All API calls have both success and error callbacks defined	Check
Optional but recommended: closures are used to keep track of which trip is selected	Nice use of a closure!
HTML is semantic	Check
CSS is DRY, uses CSS Grid, Flexbox, and/or Bootstrap	Minimal Styling
Overall	You hit most of the learning goals here. You didn't get the post request done, and you have some errors in ironically reporting errors. Take a look at my inline comments and let me know if you have questions.

[CheezItMan]

It would also be appropriate to have error.response in your if statement to verify if there is a response object in error. Network errors won't have this.

[CheezItMan]

Nice use of a closure.

[CheezItMan]

Shouldn't this be $('#reservation-form').submit instead?

[CheezItMan]

You need a slash between tripAPI and tripID