Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ports - Angela #26

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Ports - Angela #26

wants to merge 4 commits into from

Conversation

AngelaOh
Copy link

@AngelaOh AngelaOh commented Jun 3, 2019

TREK

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What does it mean for code to be asynchronous? Multiple requests can be happening at the same time.
Describe a piece of your code that executes asynchronously. How did this affect the way you structured it? A GET request for a specific trip can happen at the same time as a GET request for all trips.
What kind of errors might the API give you? How did you choose to handle them? an API could give you a 404 not found or a 429 too many requests. I can display these requests at the top of page to show the user and console.log for devs.
Suppose you needed to routinely find a specific Trip in the list by it's ID field. Would it be advantageous to keep the list in order by the id field? Explain why or why not. It may be helpful for the order to be based on the number of times it has been clicked if certain places are known to be more popular than others.

@CheezItMan
Copy link

TREK

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Not nearly enough commits, Good commit messages
Comprehension questions Check
Functionality
Click a button to load and view a list of trips Check
Clicking the "load" button twice does not cause each trip to display twice Check
Click a trip to load and view trip details Check
Clicking a different trip loads different details Check
Open network tab, then fill out a form to reserve a spot The form is there
Submitting the form only sends one POST request MISSING No submission handler is there
Errors are reported to the user Basic errors are handled
Site is clearly laid out and easy to navigate Basic styling is in place
Under the Hood
Callback functions are not nested more than 2 levels deep Check
Callback functions are given descriptive names Check
Code is generally well-organized and easy to read What is there is well organized
All API calls have both success and error callbacks defined Yes on the GET requests.
HTML is semantic Check
CSS is DRY, uses CSS Grid, Flexbox, and/or Bootstrap Basic styling is in place
Overall What you have done is working well. You are missing the POST request to register for trips. You hit the learning goals for waves 1-2, and just needed wave 3 to complete.


axios.get(TRIPSURL + `/${id}`)
.then((response) => {
let tripInfo = response.data

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be a const

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants