Ports - Sopheary

[sophearychiv]

TREK

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
What does it mean for code to be asynchronous?
Describe a piece of your code that executes asynchronously. How did this affect the way you structured it?
What kind of errors might the API give you? How did you choose to handle them?
Suppose you needed to routinely find a specific Trip in the list by it's ID field. Would it be advantageous to keep the list in order by the id field? Explain why or why not.

[kaidamasaki]

TREK

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	👍🏼
Comprehension questions	👎🏼 (No comprehension questions.)
Functionality
Click a button to load and view a list of trips	👍🏼
Clicking the "load" button twice does not cause each trip to display twice	👍🏼
Click a trip to load and view trip details	👍🏼
Clicking a different trip loads different details	👍🏼
Open network tab, then fill out a form to reserve a spot	👍🏼
Submitting the form only sends one POST request	👍🏼
Errors are reported to the user	👍🏼
Site is clearly laid out and easy to navigate	👍🏼
Under the Hood
Callback functions are not nested more than 2 levels deep	👎🏼
Callback functions are given descriptive names	👍🏼
Code is generally well-organized and easy to read	👍🏼
All API calls have both success and error callbacks defined	You used async and await instead of using the .then method on Axios requests. While these are neat features the code would be cleaner if you handled the success and failure cases the same way.
Optional but recommended: closures are used to keep track of which trip is selected
HTML is semantic	👎🏼 You skip straight from an <h1> to an <h4> though. Headers should go in order. Also, your reservation form isn't a <form> and your list of trips should be a <ul>.
CSS is DRY, uses CSS Grid, Flexbox, and/or Bootstrap	👍🏼
Overall	Overall this is a solid solution. It seems like you're still having a little trouble with semantic HTML and nesting your logic a little too deeply. This was a hectic week but all things considered it was pretty strong.