Raisah #28
Open
Raisah #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Mar 12, 2020
Comment on lines
+5
to
7
| # Time Complexity: O(nm) because the method will always iterate through each string (n) in strings and then each string will be compared to all hashes (m) that have been created, which in the worst case could be the same as the number of strings | ||
| # Space Complexity: O(n) because the size of anagrams_grouped and hash_groups will grow linearly with the size of strings in the worse case | ||
| def grouped_anagrams(strings) |
There was a problem hiding this comment.
This works with good time/space complexity, but could use with some refactoring.
Comment on lines
+52
to
54
| # Time Complexity: O(nlogn) because the sort_by method will have the time complexity of quick sort | ||
| # Space Complexity: O(n) because the size of the variables will change linearly with the size of list | ||
| def top_k_frequent_elements(list, k) |
Comment on lines
+88
to
90
| # Time Complexity: O(n) because at method must go through the table 3 times to check for each sceniario to be valid (row, column, 3x3 grid) | ||
| # Space Complexity: O(1) because the size of the variables created is constant. (if the grid is greater than 9x9 this might change for the corners array) | ||
| def valid_sudoku(table) |
There was a problem hiding this comment.
This works, but the method is pretty long and could use some refactoring. Maybe breaking some things into helper methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hash Table Practice
Congratulations! You're submitting your assignment!
Comprehension Questions