Daniela - Leaves #36
Open
Daniela - Leaves #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Mar 12, 2020
lib/exercises.rb
Outdated
Comment on lines
5
to
11
| # Time Complexity: n^2 as for each word in the list I'm iterating over the letters. | ||
|
|
||
| # # Space Complexity: O(n) because if none of the words are anagrams, | ||
| # I will duplicate the array. Also, I will create a hash were each key is each word. | ||
|
|
||
|
|
||
| def grouped_anagrams(strings) |
There was a problem hiding this comment.
This is actually O(n * m) where m is the length of the strings. Or O(n) if the words are limited in size.
Good use of a hash as a key to another hash!
|
@CheezItMan I just submitted my second exercise. Can you review it when you have a chance? I would appreciate your feedback. TY!! |
CheezItMan
reviewed
Jun 22, 2020
| end | ||
| # Time Complexity: O(kn) | ||
| # Space Complexity: O(n) | ||
| def top_k_frequent_elements(list, k) |
Comment on lines
+4
to
+7
| # Time Complexity: O(n * m) as for each word in the list I'm iterating over the letters. | ||
| # # Space Complexity: O(n). | ||
|
|
||
| def grouped_anagrams(strings) | ||
| raise NotImplementedError, "Method hasn't been implemented yet!" | ||
| def grouped_anagrams(list_strings) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hash Table Practice
Congratulations! You're submitting your assignment!
Comprehension Questions