-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Branches, Kristy #44
base: master
Are you sure you want to change the base?
Branches, Kristy #44
Conversation
Task ListWhat We're Looking For
Well done on this project, Kristy! The app code and test code look great-- clean and functioning perfectly! I've added only a few comments. That being said, this project was well done... keep up the good work! |
task = params[:id] | ||
@task = Task.find_by(id: task) | ||
if @task.nil? | ||
flash[:error] = "Could not find task with id: #{task}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You probably weren't able to use flash
meaningfully-- we will learn about flash
so very very soon!
end | ||
|
||
# Complete for Wave 4 | ||
describe "toggle_complete" do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic tests for the toggle_complete
functionality! The last remaining edge case is trying to do this with an invalid id.
Task List
Congratulations! You're submitting your assignment!
Comprehension Questions