Angele Z #41
Open
Angele Z #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One for empty tree, one for tree_with_nodes
Add a test for the height method
CheezItMan
reviewed
Feb 27, 2020
lib/tree.rb
Outdated
Comment on lines
19
to
21
| # Time Complexity: O(logn) in worst case scenario | ||
| # Space Complexity: O(1) always just adding 1 new node | ||
| def add(key, value) |
There was a problem hiding this comment.
Actually O(log n) is the best and average case runtime.
Since you're doing recursion, you do incur some space complexity.
There was a problem hiding this comment.
@CheezItMan for the time complexity - would it be O(n) for worst case, and is that possible only if the tree is unbalanced?
lib/tree.rb
Outdated
Comment on lines
37
to
39
| # Time Complexity: O(logn) since binary | ||
| # Space Complexity: O(1) since adding nothing new | ||
| def find(key) |
There was a problem hiding this comment.
Similar issues with time/space to add
lib/tree.rb
Outdated
Comment on lines
55
to
57
| # Time Complexity: O(n) since going to each node once, backtracking but still backtracking a smaller number of times than there are nodes, so it depends on the number of nodes no matter what. | ||
| # Space Complexity: O(1) - nothing being made | ||
| def inorder |
There was a problem hiding this comment.
Space complexity is O(n) since you're building an array!
Comment on lines
+72
to
74
| # Time Complexity: same as inorder | ||
| # Space Complexity: same as inorder | ||
| def preorder |
Comment on lines
+87
to
89
| # Time Complexity: same as inorder | ||
| # Space Complexity: same as inorder | ||
| def postorder |
lib/tree.rb
Outdated
Comment on lines
102
to
104
| # Time Complexity: O(n) since each node is visited once | ||
| # Space Complexity: O(1) since it doesn't make anything new | ||
| def height |
There was a problem hiding this comment.
The method works, but you have recursion and so some space complexity. Predictions?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.