PR-2: function method added #2
Conversation
| def function(n) | ||
| if n == 0 | ||
| 1 | ||
| else | ||
| n * function(n-1) | ||
| end | ||
| end |
There was a problem hiding this comment.
Consider if n < 0 or n is not an integer
Worth writing a simple loop for space efficiency?
Consider adding unit tests
There was a problem hiding this comment.
| def function(n) | |
| if n == 0 | |
| 1 | |
| else | |
| n * function(n-1) | |
| end | |
| end | |
| def function(n) | |
| if n == 0 | |
| 1 | |
| else | |
| n * function(n-1) | |
| end | |
| end |
Can you make it more clear what this function is attempting to do?
| @@ -0,0 +1,9 @@ | |||
|
|
|||
| def function(n) | |||
There was a problem hiding this comment.
Maybe consider a more descriptive name for this function?
| @@ -0,0 +1,9 @@ | |||
|
|
|||
| def function(n) | |||
| if n == 0 | |||
| if n == 0 | ||
| 1 | ||
| else | ||
| n * function(n-1) |
There was a problem hiding this comment.
maybe consider explicit returns for clarity?
| if n == 0 | ||
| 1 | ||
| else | ||
| n * function(n-1) | ||
| end |
There was a problem hiding this comment.
Consider: Ternary operator? It would make the code more readable.
| @@ -0,0 +1,9 @@ | |||
|
|
|||
| def function(n) | |||
There was a problem hiding this comment.
| def function(n) | |
| def factorial(n) |
Maybe this method could use a more descriptive name
| @@ -0,0 +1,9 @@ | |||
|
|
|||
| def function(n) | |||
There was a problem hiding this comment.
Consider naming the function a descriptive name to indicate what the function does
| if n == 0 | ||
| 1 | ||
| else | ||
| n * function(n-1) |
There was a problem hiding this comment.
Consider the case where n < 1, which will cause a stack overflow
| @@ -0,0 +1,9 @@ | |||
|
|
|||
No description provided.