PR 7: Node class #7
Conversation
| printList() { | ||
| let current = this; | ||
|
|
||
| while (current != null) { | ||
| console.log(current.value); | ||
| current = current.getNext(); | ||
| } | ||
| } |
There was a problem hiding this comment.
It may be better to convert this into a toString() method and have console.log() called on Node outside of the class in case of any unwanted print messages.
There was a problem hiding this comment.
Consider: Perhaps a function to printList should probably live in the list class (not in the node).
| constructor(value, next) { | ||
| this.value = value; | ||
| this.next = next; | ||
| } |
There was a problem hiding this comment.
Assuming this is for a linked list, it may help to add validations to ensure next is also a Node -- Otherwise, some comments about what each field represents could help clarify the constructor's post conditions.
There was a problem hiding this comment.
Also, can next node be be given default null value to account for if the next value is not given (end of list)?
There was a problem hiding this comment.
Don't know if this is possible in js, maybe will be taken care of in the linked list class
| printList() { | ||
| let current = this; | ||
|
|
||
| while (current != null) { |
There was a problem hiding this comment.
| while (current != null) { | |
| while (current) { |
(nit) null is falsy in Javascript, which allows the while loop to check through while(current).
| setNext(next) { | ||
| this.next = next; | ||
| } |
There was a problem hiding this comment.
I believe this is already set in the constructor, therefor not necessary.
| setValue(value) { | ||
| this.value = value; | ||
| } |
There was a problem hiding this comment.
This is also already set in the constructor. So not necessary?
There was a problem hiding this comment.
Thank you for the confirmation, I was starting to doubt myself lol
There was a problem hiding this comment.
I think you can still have a set method if you only want to change one field, but I also don't think it's recommended either way?
No description provided.