water-marj #49

Schmarj3 · 2020-11-17T17:39:15Z

Media Ranker

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Describe a custom model method you wrote.	none yet, but plan to make some for top_ten and spotlight
Describe how you approached testing that model method. What edge cases did you come up with?	Was able to do some validation test using filters? in a .yml file
What are `session` and `flash`? What is the difference between them?	Sessions are cookies the follow a user as the go through a site, and flash is just there for one response request cycle
What was one thing that you gained more clarity on through this assignment?	associations, although I gained more clarity, I am not sure if I have used it correctly. Also how different models and be called in different controllers!! I had not wrapped my head around that.
What is the Heroku URL of your deployed application?

Assignment Submission: Media Ranker

Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.

Reflection

Prompt	Response
What was a custom model method you wrote? What was it responsible for doing?
Describe how you approached testing that model method. What edge cases did you come up with?
What are `session` and `flash`? What is the difference between them?
What was one thing that you gained more clarity on through this assignment?
What is the Heroku URL of your deployed application?

kaidamasaki

It looks like this was a rough week for you. It looks like you didn't get around to implementing voting or any of the features from the later waves.

The code you did write looked good though.

You should definitely refresh on model testing after this though because it was a major learning goal. If you can try to work on some of the model tests for bEtsy.

Media Ranker

Functional Requirements: Manual Testing

Criteria	yes/no
Before logging in	--
1. On index page, there are at most 10 pieces of media on three lists, and a Media Spotlight	More than 10 pieces of media appear on the homepage.
2. Can go into a work's show page	✔️
3. Verify unable to vote on a work, and get a flash message
4. Can edit this work successfully, and get a flash message	Missing flash message.
5. Can go to "View all media" page and see three lists of works, sorted by vote	Not sorted by votes.
6. Verify unable to create a new work when the form is empty, and details about the validation errors are visible to the user through a flash message	✔️
7. Can create a new work successfully. Note the URL for this work's show page	✔️
8. Can delete this work successfully	✔️
9. Going back to the URL of this deleted work's show page produces a 404 or some redirect behavior (and does not try to produce a broken view)	Produces broken view.
10. Verify that the "View all users" page lists no users	Includes seeded users.
Log in	--
11. Logging in with a valid name changes the UI to "Logged in as" and "Logout" buttons
12. Your username is listed in "View all users" page	✔️
13. Verify that number of votes determines the Media Spotlight
14. Voting on several different pieces of media affects the "Votes" tables shown in the work's show page and the user's show page
15. Voting on the same work twice produces an error and flash message, and there is no extra vote	✔️
Log out	--
16. Logging out showed a flash message and changed the UI
17. Logging in as a new user creates a new user	✔️
18. Logging in as an already existing user has a specific flash message	✔️

Major Learning Goals/Code Review

Criteria	yes/no
1. Sees the full development cycle including deployment, and the app is deployed to Heroku
2. Practices full-stack development and fulfilling story requirements: the styling, look, and feel of the app is similar to the original Media Ranker
3. Practices git with at least 25 small commits and meaningful commit messages	✔️

Previous Rails learning, Building Complex Model Logic, DRYing up Rails Code

Criteria	yes/no
4. Routes file uses `resources` for works	✔️
5. Routes file shows intention in limiting routes for voting, log-in functionality, and users	✔️
6. The homepage view, all media view, and new works view use semantic HTML	✔️
7. The homepage view, all media view, and new works view use partials when appropriate	✔️
8. The model for media (likely named `work.rb`) `has_many` votes	✔️
9. The model for media has methods to describe business logic, specifically for top ten and top media, possibly also for getting works by some category
10. Some controller, likely the `ApplicationController`, has a controller filter for finding a logged in user	✔️
11. Some controller, likely the `WorksController`, has a controller filter for finding a work	✔️
12. The `WorksController` uses strong params	✔️
13. The `WorksController`'s code style is clean, and focused on working with requests, responses, `params`, `session`, `flash`	✔️

Testing Rails Apps

Criteria	yes/no
14. There are valid fixtures files used for users, votes, and works
15. User model has tests with sections on validations (valid and invalid) and relationships (has votes)
16. Vote model has tests with sections on validations (valid and invalid) and relationships (belongs to a user, belongs to a vote)
17. Work model has tests with sections on validations (valid and invalid) and relationships (has votes)	✔️
18. Work model has tests with a section on all business logic methods in the model, including their edge cases

Overall Feedback

Overall Feedback	Criteria	yes/no
Green (Meets/Exceeds Standards)	14+ in Functional Requirements: Manual Testing && 14+ in Code Review
Yellow (Approaches Standards)	12+ in Functional Requirements: Manual Testing && 11+ in Code Review, or the instructor judges that this project needs special attention
Red (Not at Standard)	0-10 in Code Review or 0-11 in Functional Reqs, or assignment is breaking/doesn’t run with less than 5 minutes of debugging, or the instructor judges that this project needs special attention	✔️

kaidamasaki · 2020-11-20T00:52:17Z

app/controllers/users_controller.rb

@@ -0,0 +1,101 @@
+class UsersController < ApplicationController
+  skip_before_action :require_login, only: [:upvote] #g


I'm pretty sure you meant for this to be a before_action and not a skip_before_action.

Suggested change

skip_before_action :require_login, only: [:upvote] #g

before_action :require_login, only: [:upvote] #g

kaidamasaki · 2020-11-20T21:14:06Z

app/controllers/users_controller.rb

+
+  def show
+    @user = User.find_by(id: params[:id])
+    return :not_found if @user.nil?


You need to use the head method here or else Rails will try to render the view.

Suggested change

return :not_found if @user.nil?

return head :not_found if @user.nil?

'

kaidamasaki

Great job! You seem to have taken the feedback to heart and really improved over last time. Congratulations!

Media Ranker

Functional Requirements: Manual Testing

Criteria	yes/no
Before logging in	--
1. On index page, there are at most 10 pieces of media on three lists, and a Media Spotlight	✔️
2. Can go into a work's show page	✔️
3. Verify unable to vote on a work, and get a flash message	✔️
4. Can edit this work successfully, and get a flash message	✔️
5. Can go to "View all media" page and see three lists of works, sorted by vote	✔️
6. Verify unable to create a new work when the form is empty, and details about the validation errors are visible to the user through a flash message	✔️
7. Can create a new work successfully. Note the URL for this work's show page	✔️
8. Can delete this work successfully	✔️
9. Going back to the URL of this deleted work's show page produces a 404 or some redirect behavior (and does not try to produce a broken view)	✔️
10. Verify that the "View all users" page lists no users	✔️
Log in	--
11. Logging in with a valid name changes the UI to "Logged in as" and "Logout" buttons	✔️
12. Your username is listed in "View all users" page	✔️
13. Verify that number of votes determines the Media Spotlight	✔️
14. Voting on several different pieces of media affects the "Votes" tables shown in the work's show page and the user's show page	✔️
15. Voting on the same work twice produces an error and flash message, and there is no extra vote	✔️
Log out	--
16. Logging out showed a flash message and changed the UI	✔️
17. Logging in as a new user creates a new user	✔️
18. Logging in as an already existing user has a specific flash message	✔️

Major Learning Goals/Code Review

Criteria	yes/no
1. Sees the full development cycle including deployment, and the app is deployed to Heroku	✔️
2. Practices full-stack development and fulfilling story requirements: the styling, look, and feel of the app is similar to the original Media Ranker	✔️
3. Practices git with at least 25 small commits and meaningful commit messages	✔️

Previous Rails learning, Building Complex Model Logic, DRYing up Rails Code

Criteria	yes/no
4. Routes file uses `resources` for works	✔️
5. Routes file shows intention in limiting routes for voting, log-in functionality, and users	✔️
6. The homepage view, all media view, and new works view use semantic HTML	✔️
7. The homepage view, all media view, and new works view use partials when appropriate	✔️
8. The model for media (likely named `work.rb`) `has_many` votes	✔️
9. The model for media has methods to describe business logic, specifically for top ten and top media, possibly also for getting works by some category	✔️
10. Some controller, likely the `ApplicationController`, has a controller filter for finding a logged in user	✔️
11. Some controller, likely the `WorksController`, has a controller filter for finding a work	✔️
12. The `WorksController` uses strong params	✔️
13. The `WorksController`'s code style is clean, and focused on working with requests, responses, `params`, `session`, `flash`	✔️

Testing Rails Apps

Criteria	yes/no
14. There are valid fixtures files used for users, votes, and works	✔️
15. User model has tests with sections on validations (valid and invalid) and relationships (has votes)	✔️
16. Vote model has tests with sections on validations (valid and invalid) and relationships (belongs to a user, belongs to a vote)	✔️
17. Work model has tests with sections on validations (valid and invalid) and relationships (has votes)	Insufficient invalid validation tests.
18. Work model has tests with a section on all business logic methods in the model, including their edge cases	✔️

Overall Feedback

Overall Feedback	Criteria	yes/no
Green (Meets/Exceeds Standards)	14+ in Functional Requirements: Manual Testing && 14+ in Code Review	✔️
Yellow (Approaches Standards)	12+ in Functional Requirements: Manual Testing && 11+ in Code Review, or the instructor judges that this project needs special attention
Red (Not at Standard)	0-10 in Code Review or 0-11 in Functional Reqs, or assignment is breaking/doesn’t run with less than 5 minutes of debugging, or the instructor judges that this project needs special attention

kaidamasaki · 2020-12-03T18:40:08Z

app/controllers/users_controller.rb

+    @user = User.new(user_params)
+    if @user.save
+      flash[:success] = "#{@user.title} was successfully added!"
+      redirect_to User_path(@user.id)


This should be lower case here. I'm actually surprised Rails is chill about the casing here.

Suggested change

redirect_to User_path(@user.id)

redirect_to user_path(@user.id)

kaidamasaki · 2020-12-03T18:41:07Z

app/controllers/users_controller.rb

+      if ! user.save
+        flash[:error] = "Unable to login"
+      end


I'd generally use an unless here to be clearer:

Suggested change

if ! user.save

flash[:error] = "Unable to login"

end

unless user.save

flash[:error] = "Unable to login"

end

kaidamasaki · 2020-12-03T21:04:15Z

app/controllers/users_controller.rb

+        flash[:error] = "Sorry, you have already cast your vote for this work."
+      else
+        new_vote = Vote.new({user_id: @user.id, work_id: @work.id})
+        new_vote.save


You should either verify that this succeeded or use save! so it will raise if there is an error:

Suggested change

new_vote.save

new_vote.save!

kaidamasaki · 2020-12-03T21:04:34Z

app/controllers/users_controller.rb

+  def require_login
+    unless current_user
+      flash[:error] = "You must be logged in to vote."
+      redirect_back(fallback_location:"/")


redirect_back 🎉

kaidamasaki · 2020-12-03T21:07:07Z

app/controllers/works_controller.rb

+  end
+
+  def show
+    return :not_found if @work.nil?


Suggested change

return :not_found if @work.nil?

return head :not_found if @work.nil?

kaidamasaki · 2020-12-03T21:10:06Z

app/controllers/works_controller.rb

+      redirect_to work_path(@work.id)
+      return
+    else
+      flash.now[:error] = "New work could not be added!"


It's helpful to include the validation errors if a work fails to save.

kaidamasaki · 2020-12-03T21:11:24Z

app/controllers/works_controller.rb

+    return params.require(:work).permit(
+        :category,
+        :title,
+        :creator,
+        :publication_year,
+        :description,
+        :user_ids)


I like the vertical formatting here. It makes it much easier to read. 😃

Schmarj3 added 30 commits November 12, 2020 10:52

Initial Rails setup

c286089

added .idea to git ignore

3272a22

added a works controller and index method

8958016

added restful route for works

4a1e990

added views for work controller

94edfb8

added method holders in work controller

8a6a1fc

added bones to works index view

e2eadb2

added html to work views, started db schema

be86819

added seed code for work

3ba12a9

added data folder and fixed work schema

d1aeeb5

added simplecov gem

7d7cdf8

added homepage view and route

a8f81bb

added some of the nav header content and links

749cdde

added base code for log in button

c4de058

added the new work link and view

73225be

completed wave 1

d8d087e

fixed validation error error, started model test

b4359fe

added yml files for tests and flash message

3339354

added user controller and model

6d6ce53

added user controller methods

f116221

added routes for users

3a192f2

added an index view for users

f63124d

added relationships to vote, user, work models

77b59e6

added logic to work model for listing votes

bf0627b

added user view html and user_seeds.csv

c459334

added link to user index page, and votes migrated to db

b2fa7fc

fixed user seeding, formated user joined date

7c15a19

added user login session logic, before_action for work controller

b626c70

added before and skip before action to user and work controllers

3d82131

added upvote button

84ec0e1

kaidamasaki reviewed Nov 20, 2020

View reviewed changes

Schmarj3 added 12 commits November 29, 2020 11:01

added upvote action

b238322

added styling

89b135a

added styling to new user form

0b1e1d6

added fixtures for testing

35e2f8d

fixed site flashes and views based on feedback checklist

0b9ebb0

added styling to homepage and user validation

397f0b8

put top_work and top_ten method logic in work model

0d9ca6e

added all user model test, some work index styling

bcbc09a

updated work model tests to use fixtures

c634b14

added relationship test for vote model

404d243

added Kaida's suggested changes from the pull request

7bdc0db

'

removed current_user method test, no path for current_user

ff7d3ed

kaidamasaki reviewed Dec 3, 2020

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

water-marj #49

water-marj #49

Schmarj3 commented Nov 17, 2020

kaidamasaki left a comment

kaidamasaki Nov 20, 2020

kaidamasaki Nov 20, 2020

kaidamasaki left a comment

kaidamasaki Dec 3, 2020

kaidamasaki Dec 3, 2020

kaidamasaki Dec 3, 2020

kaidamasaki Dec 3, 2020

kaidamasaki Dec 3, 2020

kaidamasaki Dec 3, 2020

kaidamasaki Dec 3, 2020

		@@ -0,0 +1,101 @@
		class UsersController < ApplicationController
		skip_before_action :require_login, only: [:upvote] #g

	skip_before_action :require_login, only: [:upvote] #g
	before_action :require_login, only: [:upvote] #g

	return :not_found if @user.nil?
	return head :not_found if @user.nil?

	redirect_to User_path(@user.id)
	redirect_to user_path(@user.id)

	return :not_found if @work.nil?
	return head :not_found if @work.nil?

water-marj #49

Are you sure you want to change the base?

water-marj #49

Conversation

Schmarj3 commented Nov 17, 2020

Media Ranker

Comprehension Questions

Assignment Submission: Media Ranker

Reflection

kaidamasaki left a comment

Choose a reason for hiding this comment

Media Ranker

Functional Requirements: Manual Testing

Major Learning Goals/Code Review

Previous Rails learning, Building Complex Model Logic, DRYing up Rails Code

Testing Rails Apps

Overall Feedback

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kaidamasaki left a comment

Choose a reason for hiding this comment

Media Ranker

Functional Requirements: Manual Testing

Major Learning Goals/Code Review

Previous Rails learning, Building Complex Model Logic, DRYing up Rails Code

Testing Rails Apps

Overall Feedback

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment