Fire - Ayesha's Media ranker submission

[ayaseef]

Media Ranker

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Describe a custom model method you wrote.	To view the highest voted piece of work as "spotlight"
Describe how you approached testing that model method. What edge cases did you come up with?	I am still working on writing tests for these. Most of the tests in my project are broken as yet.
What are session and flash? What is the difference between them?	Flash is used to flash messages when redirecting to a page, for example when the user logs in successfully, I flash a message in that "session" that the login was successful.
What was one thing that you gained more clarity on through this assignment?	The uber MVC concept. However, I failed at tests.
What is the Heroku URL of your deployed application?	I have not deployed the site as yet. I am still working on it.

Assignment Submission: Media Ranker

Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.

Reflection

Prompt	Response
What was a custom model method you wrote? What was it responsible for doing?
Describe how you approached testing that model method. What edge cases did you come up with?
What are session and flash? What is the difference between them?
What was one thing that you gained more clarity on through this assignment?
What is the Heroku URL of your deployed application?

[jmaddox19]

Media Ranker

Great work!

There are certainly a couple broken pieces and a couple things missing but you got login and vote working (which require understanding of the biggest new concepts we introduced) and wrote some good model tests!

You built a whole site users can log into, interact with, and vote to change the way things are ordered! That's a lot! I hope you've been able to celebrate this big win!

Functional Requirements: Manual Testing

Criteria	yes/no
Before logging in	--
1. On index page, there are at most 10 pieces of media on three lists, and a Media Spotlight	You chose to make the main homepage the works index page instead of the top media page which isn't a big deal, just confused me a little. However the top media page is not working. When I navigate to it, I get the following Rails error: undefined local variable or method spotlight'`. It looks like you might not have manually tested out this page after making some changes.
2. Can go into a work's show page	✔️
3. Verify unable to vote on a work, and get a flash message	✔️
4. Can edit this work successfully, and get a flash message	When I try to edit a work, it doesn't update it successfully and I get the following flash message "This particular work does not exist". See inline comments to an explanation about why!
5. Can go to "View all media" page and see three lists of works, sorted by vote	They are there but not sorted by vote
6. Verify unable to create a new work when the form is empty, and details about the validation errors are visible to the user through a flash message	✔️
7. Can create a new work successfully. Note the URL for this work's show page	I can't create a work because when I enter "2018" I get the following flash error: Publication_year Enter the year in mumaric value. I imagine there's an issue where string should be converted to integer in the code.
8. Can delete this work successfully	Delete not working. See inline comments for explanation about why
9. Going back to the URL of this deleted work's show page produces a 404 or some redirect behavior (and does not try to produce a broken view)	✔️ I used the console to delete a work to verify this behavior
10. Verify that the "View all users" page lists no users	✔️
Log in	--
11. Logging in with a valid name changes the UI to "Logged in as" and "Logout" buttons	✔️
12. Your username is listed in "View all users" page	✔️
13. Verify that number of votes determines the Media Spotlight	Can't view spotlight due to broken view
14. Voting on several different pieces of media affects the "Votes" tables shown in the work's show page and the user's show page	✔️
15. Voting on the same work twice produces an error and flash message, and there is no extra vote	✔️
Log out	--
16. Logging out showed a flash message and changed the UI	✔️
17. Logging in as a new user creates a new user	✔️
18. Logging in as an already existing user has a specific flash message	✔️

Major Learning Goals/Code Review

Criteria	yes/no
1. Sees the full development cycle including deployment, and the app is deployed to Heroku	No but not required
2. Practices full-stack development and fulfilling story requirements: the styling, look, and feel of the app is similar to the original Media Ranker	✔️
3. Practices git with at least 25 small commits and meaningful commit messages	The commits look pretty small with pretty clear messages, until that last 3 or 4 commits, where it looks like perhaps you forgot to commit as frequently

Previous Rails learning, Building Complex Model Logic, DRYing up Rails Code

Criteria	yes/no
4. Routes file uses resources for works	✔️
5. Routes file shows intention in limiting routes for voting, log-in functionality, and users	✔️ Yes, other than a couple confusing lines at the top of the file
6. The homepage view, all media view, and new works view use semantic HTML	✔️
7. The homepage view, all media view, and new works view use partials when appropriate	No partial views. I would encourage you to practice with partial views on a future project
8. The model for media (likely named work.rb) has_many votes	✔️
9. The model for media has methods to describe business logic, specifically for top ten and top media, possibly also for getting works by some category	✔️
10. Some controller, likely the ApplicationController, has a controller filter for finding a logged in user
11. Some controller, likely the WorksController, has a controller filter for finding a work
12. The WorksController uses strong params	✔️
13. The WorksController's code style is clean, and focused on working with requests, responses, params, session, flash	✔️ Yes, aside from the missed opportunity to use controller filters, as noted above

Testing Rails Apps

Criteria	yes/no
14. There are valid fixtures files used for users, votes, and works	✔️
15. User model has tests with sections on validations (valid and invalid) and relationships (has votes)	✔️
16. Vote model has tests with sections on validations (valid and invalid) and relationships (belongs to a user, belongs to a vote)	✔️
17. Work model has tests with sections on validations (valid and invalid) and relationships (has votes)	✔️
18. Work model has tests with a section on all business logic methods in the model, including their edge cases

Overall Feedback

Overall Feedback	Criteria	yes/no
Green (Meets/Exceeds Standards)	14+ in Functional Requirements: Manual Testing && 14+ in Code Review
Yellow (Approaches Standards)	12+ in Functional Requirements: Manual Testing && 11+ in Code Review, or the instructor judges that this project needs special attention	✔️
Red (Not at Standard)	0-10 in Code Review or 0-11 in Functional Reqs, or assignment is breaking/doesn’t run with less than 5 minutes of debugging, or the instructor judges that this project needs special attention

Code Style Bonus Awards

Was the code particularly impressive in code style for any of these reasons (or more...?)

Quality	Yes?
Perfect Indentation	✅
Elegant/Clever	✅
Descriptive/Readable	✅
Concise	✅
Logical/Organized	✅

[jmaddox19]

@work will always be nil here because it's scope doesn't carry over from the other methods from previous requests.
The same two lines you have at the top of the show action belong at the top of this action and the destroy action.

Suggested change

	if @work.nil?
	work_id = params[:id]
	@work = Work.find_by(id: work_id)
	if @work.nil?

[jmaddox19]

Are these meant to be here? I don't believe these are doing anything without a to argument.

[jmaddox19]

This isn't being called anywhere so it would be cleaner to delete it.
If it isn't clear that Vote.create() doesn't call this method, that's definitely something worth chatting with a classmate, instructor, or TA about to get clarity on.