Earth - Schanen #57
Open
Earth - Schanen #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… application.html.erb.
Single vote logic written, flash bar added & works index partial.
CheezItMan
reviewed
Dec 6, 2020
There was a problem hiding this comment.
Media Ranker
Functional Requirements: Manual Testing
| Criteria | yes/no |
|---|---|
| Before logging in | -- |
| 1. On index page, there are at most 10 pieces of media on three lists, and a Media Spotlight | ✔️ |
| 2. Can go into a work's show page | ✔️ |
| 3. Verify unable to vote on a work, and get a flash message | ✔️, sort of, see my note in the votescontroller. You're returning prior to redirecting them back. The flash notice shows up later. |
| 4. Can edit this work successfully, and get a flash message | |
| 5. Can go to "View all media" page and see three lists of works, sorted by vote | ✔️? |
| 6. Verify unable to create a new work when the form is empty, and details about the validation errors are visible to the user through a flash message | ✔, It prevents the model from being created, but the validation errors are not shown... |
| 7. Can create a new work successfully. Note the URL for this work's show page | ✔️ |
| 8. Can delete this work successfully | ✔️ |
| 9. Going back to the URL of this deleted work's show page produces a 404 or some redirect behavior (and does not try to produce a broken view) | ✔️, although a flash notice would be nice |
| 10. Verify that the "View all users" page lists no users | ✔️ |
| Log in | -- |
| 11. Logging in with a valid name changes the UI to "Logged in as" and "Logout" buttons | ✔️ |
| 12. Your username is listed in "View all users" page | ✔️ |
| 13. Verify that number of votes determines the Media Spotlight | ✔️ |
| 14. Voting on several different pieces of media affects the "Votes" tables shown in the work's show page and the user's show page | ✔️ |
| 15. Voting on the same work twice produces an error and flash message, and there is no extra vote | ✔️, yes, but it just says it couldn't do it, not why. See my inline notice in the votes controller create method. |
| Log out | -- |
| 16. Logging out showed a flash message and changed the UI | ✔️ |
| 17. Logging in as a new user creates a new user | ✔️ |
| 18. Logging in as an already existing user has a specific flash message | ✔️ |
Major Learning Goals/Code Review
| Criteria | yes/no |
|---|---|
| 1. Sees the full development cycle including deployment, and the app is deployed to Heroku | ✔️ |
| 2. Practices full-stack development and fulfilling story requirements: the styling, look, and feel of the app is similar to the original Media Ranker | |
| 3. Practices git with at least 25 small commits and meaningful commit messages | ✔️, 26 commits, just enough 😜 |
Previous Rails learning, Building Complex Model Logic, DRYing up Rails Code
| Criteria | yes/no |
|---|---|
4. Routes file uses resources for works |
✔️ |
| 5. Routes file shows intention in limiting routes for voting, log-in functionality, and users | ✔️, improved! |
| 6. The homepage view, all media view, and new works view use semantic HTML | ✔️ |
| 7. The homepage view, all media view, and new works view use partials when appropriate | ✔️ Sweet! |
8. The model for media (likely named work.rb) has_many votes |
✔️ |
| 9. The model for media has methods to describe business logic, specifically for top ten and top media, possibly also for getting works by some category | |
10. Some controller, likely the ApplicationController, has a controller filter for finding a logged in user |
✔️ |
11. Some controller, likely the WorksController, has a controller filter for finding a work |
✔️ |
12. The WorksController uses strong params |
✔️ |
13. The WorksController's code style is clean, and focused on working with requests, responses, params, session, flash |
✔️, Greatly improved here. 😻 |
Testing Rails Apps
| Criteria | yes/no |
|---|---|
| 14. There are valid fixtures files used for users, votes, and works | ✔️ Nice! |
| 15. User model has tests with sections on validations (valid and invalid) and relationships (has votes) | ✔️ |
| 16. Vote model has tests with sections on validations (valid and invalid) and relationships (belongs to a user, belongs to a vote) | ✔️ |
| 17. Work model has tests with sections on validations (valid and invalid) and relationships (has votes) | ✔️ |
| 18. Work model has tests with a section on all business logic methods in the model, including their edge cases |
Overall Feedback
| Overall Feedback | Criteria | yes/no |
|---|---|---|
| Green (Meets/Exceeds Standards) | 14+ in Functional Requirements: Manual Testing && 14+ in Code Review | 💚 |
Code Style Bonus Awards
Was the code particularly impressive in code style for any of these reasons (or more...?)
| Quality | Yes? |
|---|---|
| Perfect Indentation | ✅ |
| Descriptive/Readable | ✅ |
| Logical/Organized | ✅ |
Summary
Nice work Schanen, this is much more solid than the original submission. You had some good tests and good routing. See my inline notes on the way you are sorting the works, but otherwise this is great. Of course your styling is still minimal, but the functionality works.
Comment on lines
+5
to
+7
| resources :works do | ||
| resources :votes, only: [:create] | ||
| end |
| validates :work_id, :presence => true | ||
| validates :user_id, :presence => true | ||
|
|
||
| validates_uniqueness_of :user_id, :scope => :work_id, :message => 'user: has already voted for this work' |
Comment on lines
+17
to
+18
| return | ||
| redirect_back(fallback_location: root_path) |
There was a problem hiding this comment.
You need to do the return after you redirect them.
Suggested change
| return | |
| redirect_back(fallback_location: root_path) | |
| redirect_back(fallback_location: root_path) | |
| return |
| redirect_back(fallback_location: root_path) | ||
| return | ||
| else | ||
| flash[:error] = "A problem occurred: Could not upvote" |
There was a problem hiding this comment.
Use the darn validation error!
Suggested change
| flash[:error] = "A problem occurred: Could not upvote" | |
| flash[:error] = @vote.errors.messages[:user_id].first |
| t.string "category" | ||
| t.datetime "created_at", precision: 6, null: false | ||
| t.datetime "updated_at", precision: 6, null: false | ||
| t.integer "vote_count", default: 0 |
There was a problem hiding this comment.
I don't like this, you're better off using work.votes.count for the vote-count.
Comment on lines
+13
to
+15
| def self.order_media(category) | ||
| where(category: category).order(vote_count: :desc) | ||
| end |
There was a problem hiding this comment.
This works, but it would be easy for the vote_count attribute and the number of votes in the system to get out of alignment. For example someone in the DB deletes a vote, now they don't match!
It's better to rely on votes.count and sort using the relationship with a bit of research.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Media Ranker
Congratulations! You're submitting your assignment!
Comprehension Questions
sessionandflash? What is the difference between them?Assignment Submission: Media Ranker
Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.
Reflection
sessionandflash? What is the difference between them?