Update worksheet.rb #48
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Sep 15, 2020
| # Which layers are nested in each other? | ||
| # Which layers of data "have" within it a different layer? | ||
| # Which layers are "next" to each other? | ||
| all_drivers = [ |
There was a problem hiding this comment.
👍 , your indentation is a bit odd however.
Comment on lines
+97
to
+100
| # all_drivers.each do |driver| | ||
| # puts driver[:driver_id] + " has given" + " " + driver[:rides].length.to_s + " " + "rides." | ||
| # end | ||
|
|
There was a problem hiding this comment.
👍 , however next time uncomment what's working so I can test it easily.
Comment on lines
+102
to
+112
| # all_drivers.each do |driver| | ||
| # total_money_made = 0 | ||
| # driver_id = driver[:driver_id] | ||
| # # p driver | ||
| # | ||
| # driver[:rides].each do |num| | ||
| # ride_cost = num[:cost] | ||
| # total_money_made += ride_cost | ||
| # end | ||
| # puts "#{driver_id} earned a total of: $#{total_money_made}." | ||
| # end |
There was a problem hiding this comment.
👍 , check your indentation here and I suggest using either the .sum_by or .reduce methods to calculate the totals.
Comment on lines
+115
to
+125
| # all_drivers.each do |driver| | ||
| # driver_id = driver[:driver_id] | ||
| # ride_count = driver[:rides].length | ||
| # sum = 0 | ||
| # | ||
| # driver[:rides].each do |num| | ||
| # ride_rating = num[:rating] | ||
| # sum += ride_rating | ||
| # end | ||
| # puts "#{driver_id} has an average rating of #{sum/ride_count.to_f}." | ||
| # end |
There was a problem hiding this comment.
👍 , again I suggest using sum or reduce here as well.
Comment on lines
+130
to
+142
| # total_money_made = 0 | ||
| # driver_id = driver[:driver_id] | ||
| # | ||
| # driver[:rides].each do |num| | ||
| # ride_cost = num[:cost] | ||
| # total_money_made += ride_cost | ||
| # end | ||
| # if highest_earnings < total_money_made | ||
| # highest_earnings = total_money_made | ||
| # highest_earner_driver_id = driver_id | ||
| # end | ||
| # end |
There was a problem hiding this comment.
This is a great place to use the max method
added 2 commits
September 16, 2020 17:51
fixing tab size
|
Good feedback, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assignment Submission: Ride Share
Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.
Reflection
.map? If so, when? If not, why, or when would be a good opportunity to use it?