-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Water - Christabel #1
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Christabel, you hit the learning goals here. I left some comments on space/time complexity otherwise this is well done. Nice work!
// Time Complexity: O(log n) | ||
// Space Complexity: O(log n) | ||
add(key, value) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 The space/time complexity is O(log n) if the tree is balanced and O(n) if it's not.
// Time Complexity: O(log n) | ||
// Space Complexity: O(log n) | ||
find(key) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 The space/time complexity is O(log n) if the tree is balanced and O(n) if it's not.
// Time Complexity: O(n) | ||
// Space Complexity: O(log n) | ||
inorder() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Space and time complexities are O(n) - because of the array
// Time Complexity: O(n) | ||
// Space Complexity: O(log n) | ||
preorder() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Space and time complexities are O(n) - because of the array
// Time Complexity: O(n) | ||
// Space Complexity: O(log n) | ||
postorder() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Space and time complexities are O(n) - because of the array
// Time Complexity: O(log n) | ||
// Space Complexity: O(log n) | ||
height() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 The time complexity is O(n) since you are visiting each node and the space complexity is O(log n) if the tree is unbalanced and O(log n) if it is balanced.
No description provided.