Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Water - Christabel #1

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Water - Christabel #1

wants to merge 4 commits into from

Conversation

cescarez
Copy link

No description provided.

Copy link

@CheezItMan CheezItMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Christabel, you hit the learning goals here. I left some comments on space/time complexity otherwise this is well done. Nice work!

Comment on lines +15 to 17
// Time Complexity: O(log n)
// Space Complexity: O(log n)
add(key, value) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 The space/time complexity is O(log n) if the tree is balanced and O(n) if it's not.

Comment on lines +40 to 42
// Time Complexity: O(log n)
// Space Complexity: O(log n)
find(key) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 The space/time complexity is O(log n) if the tree is balanced and O(n) if it's not.

Comment on lines +64 to 66
// Time Complexity: O(n)
// Space Complexity: O(log n)
inorder() {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Space and time complexities are O(n) - because of the array

Comment on lines +78 to 80
// Time Complexity: O(n)
// Space Complexity: O(log n)
preorder() {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Space and time complexities are O(n) - because of the array

Comment on lines +92 to 94
// Time Complexity: O(n)
// Space Complexity: O(log n)
postorder() {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Space and time complexities are O(n) - because of the array

Comment on lines +106 to 108
// Time Complexity: O(log n)
// Space Complexity: O(log n)
height() {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 The time complexity is O(n) since you are visiting each node and the space complexity is O(log n) if the tree is unbalanced and O(log n) if it is balanced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants