Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alice D & Aimee - Fire 🔥 #21

Open
wants to merge 31 commits into
base: master
Choose a base branch
from
Open

Conversation

marks214
Copy link

@marks214 marks214 commented Jan 22, 2021

Video Store Consumer

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Paste a link to the PR for your API Ada-C14/video-store-consumer-api#17
For each person in your pair, describe something you learned from your partner during this project Aimee: I learned a lot from Alice about how to implement the check-out feature. Alice D: I learned how to implement the search feature from Aimee, among other things.
What was one area of React you gained more clarity on during this assignment? Aimee: The useEffect hook made more sense to me in this project than it did in the inspiration board project. Alice D: I gained more clarity on how two different repository could interact (front-end & back-end).
Describe how you solved the problem of having lists of movies that look mostly the same but have different content We displayed the video posters (images, with the title as alternative text for screen readers). This way the user wouldn't be overwhelmed by the text describing the movies.
Describe how you handled rentals with React We created a checkout method in App.js which makes api post request to the "checkout-url" which contains information about the title selected, the customer selected and a due-date (which is the result of calling a function from App.js that essentially adds 7 days to the current date). If the post request to rentals is successful, the user gets back an alert pop up notifying them that the video has been checked out by the customer. The function then sets back the selected customer and selected video to null values for future selections. If the checkout is not successful, the user gets an error message.
Describe a DOM event your application handled The onClick event is used for adding videos to the library. For example, when the user hovers over the video poster in the search component, there are css effects, but the html tag figcaption has an onClick event listening for the user to click it. Once clicked the imageClick function posts the video to the library.
Did you use any functional stateless components? What for? In App.js TimeStamp is a function that returns the due date, in the correct format, for the video based on the current day.
Did you use any container components? What for? Our App.js file is the main component and is a container for all the other components.
Do you have any recommendations on how we could improve this project for the next cohort? More time always helps, but for a phase 3 project there is an expectation it might not get finished, and it was really helpful to practice our skills with such a short time-frame. Having a clearer expectation for css: it wasn't a priority for this project, but showing an example of an "attractive" styling expectation would be helpful. Also, was the feedback template accurate? For example, deployment was optional, but it was listed on the feedback template.

marks214 and others added 30 commits January 19, 2021 13:21
…you try to search for a video (form not yet handled by Search.js)
…tead of text tiles. imported Select from react-select - want to make the videos selectable
drop of css, need to make video disappear after clicked
duplication validations were done on the back end
@marks214 marks214 changed the title Alice & Aimee - Fire 🔥 Alice D & Aimee - Fire 🔥 Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants