Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C15 - Katrina K #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions heaps/heap_sort.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@

from heaps.min_heap import MinHeap

def heap_sort(list):
""" This method uses a heap to sort an array.
Time Complexity: ?
Space Complexity: ?
"""
Comment on lines 3 to 7

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Time/space complexity?

pass
hold_heap = MinHeap()
for x in list:
hold_heap.add(x)

return [hold_heap.remove() for i in range(len(list))]
54 changes: 40 additions & 14 deletions heaps/min_heap.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
class HeapNode:

def __init__(self, key, value):
self.key = key
self.value = value
Expand All @@ -21,18 +21,28 @@ def __init__(self):
def add(self, key, value = None):
""" This method adds a HeapNode instance to the heap
If value == None the new node's value should be set to key
Time Complexity: ?
Space Complexity: ?
Time Complexity: O(log n)
Space Complexity: O(1) *same space is added to the list every time but the behind the scenes buffer might be using more memory than this
"""
Comment on lines 21 to 26

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 The space complexity is also log n due to the recursive call stack as you note

pass
self.store.append(HeapNode(key, (value if value else key)))
self.heap_up(len(self.store) - 1)

def remove(self):
""" This method removes and returns an element from the heap
maintaining the heap structure
Time Complexity: ?
Space Complexity: ?
Time Complexity: O(log n)
Space Complexity: O(1)
"""
Comment on lines 30 to 35

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 The space complexity is also O(log n)

pass
if len(self.store) < 1:
return

self.swap(0, len(self.store) - 1)
ret_node = self.store.pop(len(self.store) - 1)
self.heap_down(0)

print(self.store)

return ret_node.value



Expand All @@ -46,10 +56,13 @@ def __str__(self):

def empty(self):
""" This method returns true if the heap is empty
Time complexity: ?
Space complexity: ?
Time complexity: O(1)
Space complexity: O(1)
"""
pass
if len(self.store) < 1:
return True

return False
Comment on lines +62 to +65

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if len(self.store) < 1:
return True
return False
return len(self.store) == 0



def heap_up(self, index):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Due to the call stack the space complexity is O(log n)

Expand All @@ -59,18 +72,31 @@ def heap_up(self, index):
property is reestablished.

This could be **very** helpful for the add method.
Time complexity: ?
Space complexity: ?
Time complexity: O(log n)
Space complexity: O(1)
"""
pass
if index is not 0 and self.store[index].key < self.store[(index - ((index +1) %2)) // 2].key:
self.swap(index, ((index - ((index +1) %2)) // 2))
self.heap_up((index - ((index +1) %2)) // 2)

return

def heap_down(self, index):
""" This helper method takes an index and
moves the corresponding element down the heap if it's
larger than either of its children and continues until
the heap property is reestablished.
"""
pass
if len(self.store) > (index * 2 + 1) and self.store[index].key > self.store[index * 2 + 1].key:
self.swap(index, (index * 2 + 1))
self.heap_down((index * 2 + 1))
self.heap_down(index)
elif len(self.store) > (index * 2 + 2) and self.store[index].key > self.store[index * 2 + 2].key:
self.swap(index, (index * 2 + 2))
self.heap_down((index * 2 + 2))
self.heap_down(index)
Comment on lines +96 to +97

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, but you do potentially end up with an extra swap. However you avoid extra complicated conditionals.


return


def swap(self, index_1, index_2):
Expand Down