Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C15 - Hena #27

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions heaps/heap_sort.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,19 @@

from heaps.min_heap import MinHeap

def heap_sort(list):
""" This method uses a heap to sort an array.
Time Complexity: ?
Space Complexity: ?
Time Complexity: O(log n)
Space Complexity: O(n)
"""
Comment on lines 3 to 7

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 The time complexity is O(n log n) because you add n elements to a heap (n * log n) and then remove n elements from the heap O(n * log n)

pass
heap = MinHeap()

for num in list:
heap.add(num)

i = 0
while not heap.empty():
list[i] = heap.remove()
i+=1

return list

68 changes: 54 additions & 14 deletions heaps/min_heap.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,21 +21,33 @@ def __init__(self):
def add(self, key, value = None):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 However space complexity is O(1) since you just add 1 element to the heap and use an iterative solution

""" This method adds a HeapNode instance to the heap
If value == None the new node's value should be set to key
Time Complexity: ?
Space Complexity: ?
Time Complexity: O(log n)
Space Complexity: O(n)
"""
pass
if value == None:
value = key

node = HeapNode(key, value)
self.store.append(node)
node_index = len(self.store) - 1
self.heap_up(node_index)

def remove(self):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 However space complexity is O(log n)

""" This method removes and returns an element from the heap
maintaining the heap structure
Time Complexity: ?
Space Complexity: ?
Time Complexity: O(log n)
Space Complexity: O(1)
"""
pass
if self.empty():
return None

node_index = len(self.store) - 1
self.swap(0, node_index)
min = self.store.pop()
self.heap_down(0)

return min.value


def __str__(self):
""" This method lets you print the heap, when you're testing your app.
"""
Expand All @@ -46,10 +58,10 @@ def __str__(self):

def empty(self):
""" This method returns true if the heap is empty
Time complexity: ?
Space complexity: ?
Time complexity: O(1)
Space complexity: O(1)
"""
pass
return self.store == []


def heap_up(self, index):
Expand All @@ -59,18 +71,46 @@ def heap_up(self, index):
property is reestablished.

This could be **very** helpful for the add method.
Time complexity: ?
Space complexity: ?
Time complexity: O(log n)
Space complexity: O(1)
"""
pass
if index == 0:
return None

parent_index = ((index - 1) // 2)

while self.store[parent_index].key > self.store[index].key:
self.swap(parent_index, index)
self.heap_up(parent_index)

def heap_down(self, index):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

""" This helper method takes an index and
moves the corresponding element down the heap if it's
larger than either of its children and continues until
the heap property is reestablished.
"""
pass
node_index = len(self.store) - 1

if (index >= node_index):
return

left = ((2 * index) + 2)
right = ((2 * index) + 1)

if (right > node_index):
return

if right < node_index + 1:
if left >= node_index + 1:
down = right
elif self.store[right].key < self.store[left].key:
down = right
else:
down = left

if self.store[index].key > self.store[down].key:
self.swap(index, down)
self.heap_down(down)


def swap(self, index_1, index_2):
Expand Down