Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rock - Drew Taylor #40

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions heaps/heap_sort.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,17 @@
from heaps.min_heap import MinHeap


def heap_sort(list):
""" This method uses a heap to sort an array.
Time Complexity: ?
Space Complexity: ?
Time Complexity: O(n log n)
Space Complexity: O(n)
"""
Comment on lines 4 to 8

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

pass
heap = MinHeap()
for num in list:
heap.add(num)

heap_list = []
while heap.store:
num = heap.remove()
heap_list.append(num)
return heap_list
55 changes: 41 additions & 14 deletions heaps/min_heap.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
class HeapNode:

def __init__(self, key, value):
self.key = key
self.value = value
Expand All @@ -21,18 +21,30 @@ def __init__(self):
def add(self, key, value = None):
""" This method adds a HeapNode instance to the heap
If value == None the new node's value should be set to key
Time Complexity: ?
Space Complexity: ?
Time Complexity: O(log n)
Space Complexity: O(1)
"""
Comment on lines 21 to 26

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 the time/space complexities here are both O(log n)

pass
if value == None:
value = key

node = HeapNode(key, value)
self.store.append(node)
self.heap_up(len(self.store) -1)

def remove(self):
""" This method removes and returns an element from the heap
maintaining the heap structure
Time Complexity: ?
Space Complexity: ?
Time Complexity: O(log n)
Space Complexity: O(1)
"""
pass
Comment on lines 34 to -35

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

if len(self.store) == 0:
return

self.swap(0, len(self.store) - 1)
min = self.store.pop()
self.heap_down(0)

return min.value



Expand All @@ -46,10 +58,10 @@ def __str__(self):

def empty(self):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

""" This method returns true if the heap is empty
Time complexity: ?
Space complexity: ?
Time complexity: O(1)
Space complexity: O(1)
"""
pass
return len(self.store) == 0


def heap_up(self, index):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 the time/space complexities here are O(log n)

Expand All @@ -59,18 +71,33 @@ def heap_up(self, index):
property is reestablished.

This could be **very** helpful for the add method.
Time complexity: ?
Space complexity: ?
Time complexity: O(1)
Space complexity: O(1)
"""
pass
if index == 0:
return None

parent = (index -1) // 2
if self.store[index].key < self.store[parent].key:
self.swap(index, parent)
self.heap_up(parent)

def heap_down(self, index):
""" This helper method takes an index and
moves the corresponding element down the heap if it's
larger than either of its children and continues until
the heap property is reestablished.
"""
Comment on lines 85 to 90

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

pass
min_child_index = 2 * index + 1
child2_index = 2 * index + 2
if child2_index < len(self.store) and self.store[child2_index].key < self.store[min_child_index].key:
min_child_index = child2_index

if min_child_index >= len(self.store):
return None
elif self.store[min_child_index].key < self.store[index].key:
self.swap(index, min_child_index)
self.heap_down(min_child_index)


def swap(self, index_1, index_2):
Expand Down