Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rock-Saharai Cante #46

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Rock-Saharai Cante #46

wants to merge 1 commit into from

Conversation

scantea
Copy link

@scantea scantea commented Jun 8, 2021

No description provided.

Copy link

@audreyandoy audreyandoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Saharai!! I love all the pinky colors and icons you added to your portfolio. I've added a few comments about absolute vs relative paths. Let me know if you have any questions!

<script src="https://use.fontawesome.com/c0ac3b38ec.js"></script> <!--insert Linkedin and Github icons as classes -->
<title>Saharai's Personal Portfolio WebPage</title>
<meta name="viewport" content="width=device-width,initial-scale=1">
<link rel="stylesheet" type="text/css" href="/Users/ada/Developer/projects/personal-website/content/stylesheets/style_bio.css">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be careful about using absolute path, this will work on your own machine but when you push your code on a project you're working with others they won't have the same file path as you on their machines.

I recommend using relative path which describes the path starting from the root of your project. So in this case ./stylesheets/style.css which we can verbalize into:

"from the current directory I'm in . get a resource in the /stylesheets/ folders called style.css"


I welcome challenges and am driven by my curiosity and dedication to pursue a career that allows for constant growth. My prior work experience has served me greatly in optimizing my time at ADA. Operating at a graduate student level daily, working under multiple guidelines, and strategic planning, has taught me to be resourceful and to adapt. From networking to debugging, my work ethic has served me well in my commitment to follow my curiosty and pursue my passion for learning. In addition to giving me access to a great curriculum, ADA has taught me how to feel comfortable with the uncomfortable, and that has been the key to my success and a great daily reminder. Hence, now I am confident in pursuing my interests in full-stack based work. I look forward to bringing my technical and transferrable skills into the workforce and take ownership of my accomplishments and contribute to team goals.</p>
<div class="banner-btn">
<a href="/Users/ada/Developer/projects/personal-website/content/index.html"><span></span>Home</a>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same Comment as above about relative path. However, because about and index are in the same directory so there's no need to add the folder in the path.

Suggested change
<a href="/Users/ada/Developer/projects/personal-website/content/index.html"><span></span>Home</a>
<a href="index.html"><span></span>Home</a>

</nav>
</div>
<div id="menulogo">
<img src="/Users/ada/Developer/projects/personal-website/images/saharis-spirit-animal.png" id="menu">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<img src="/Users/ada/Developer/projects/personal-website/images/saharis-spirit-animal.png" id="menu">
<img src="../images/saharis-spirit-animal.png" id="menu">

In this case, images is outside of the content folder so the file path will need 2 .. which represents going to the previous directory then into images to grab your image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants