-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gloria/scissors #66
base: master
Are you sure you want to change the base?
gloria/scissors #66
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have a good start with semantic html. I left a few comments on how you can use classes to apply styles. Please let me know if you have questions about this.
</ul> </nav> </header> | ||
|
||
<section> | ||
<h2 class = highlight>Code Journal</h2> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
classes should be in quotes
<h2 class = highlight>Code Journal</h2> | |
<h2 class="highlight">Code Journal</h2> |
|
||
/* class names alphabetize */ | ||
|
||
.page-title { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't look like this class is applied to any element. Consider where this styling might be useful.
|
||
/* id */ | ||
|
||
#intro-paragraph { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't look like this id is applied to any element. Consider where this styling might be useful.
No description provided.