Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gloria/scissors #66

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

gloria/scissors #66

wants to merge 3 commits into from

Conversation

ggrossvi
Copy link

No description provided.

Copy link

@beccaelenzil beccaelenzil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have a good start with semantic html. I left a few comments on how you can use classes to apply styles. Please let me know if you have questions about this.

</ul> </nav> </header>

<section>
<h2 class = highlight>Code Journal</h2>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

classes should be in quotes

Suggested change
<h2 class = highlight>Code Journal</h2>
<h2 class="highlight">Code Journal</h2>


/* class names alphabetize */

.page-title {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't look like this class is applied to any element. Consider where this styling might be useful.


/* id */

#intro-paragraph {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't look like this id is applied to any element. Consider where this styling might be useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants