Tapasya Khatri C18 Cheetahs #102
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbieniosek
reviewed
Dec 12, 2022
Comment on lines
+32
to
+33
| <h2>About Me</h2> | ||
| <h5>Software Engineering <span>|</span> Product Design</h5> |
There was a problem hiding this comment.
In semantic HTML, heading tags should be used to indicate different sections of content, not as stylistic elements. Link
| </section> | ||
| </header> | ||
|
|
||
| <main class="about-content"> |
stylesheets/index.css
Outdated
Comment on lines
11
to
21
| body { | ||
| font-family: sans-serif; | ||
| text-align: center; | ||
| background-color: #dae1e7; | ||
| } | ||
|
|
||
| body { | ||
| display: flex; | ||
| flex-direction: column; | ||
| min-height: 100vh; | ||
| } |
There was a problem hiding this comment.
These can be combined into one section:
Suggested change
| body { | |
| font-family: sans-serif; | |
| text-align: center; | |
| background-color: #dae1e7; | |
| } | |
| body { | |
| display: flex; | |
| flex-direction: column; | |
| min-height: 100vh; | |
| } | |
| body { | |
| font-family: sans-serif; | |
| text-align: center; | |
| background-color: #dae1e7; | |
| display: flex; | |
| flex-direction: column; | |
| min-height: 100vh; | |
| } |
There was a problem hiding this comment.
Makes sense to combine. Thank you Jasmine!
| } | ||
|
|
||
| main.content { | ||
| display: flex; |
| } | ||
|
|
||
| .logo { | ||
| font-family: 'Berkshire Swash'; |
|
|
||
| span { | ||
| color: #fff; | ||
| font-family: 'Berkshire Swash', cursive; |
There was a problem hiding this comment.
Minor note - here you are setting the font-family on the parent (.logo) and here in the span. One thing that you might consider is changing this to inherit. One of the nice things about using inherit here is that if you want to test with different fonts, you only have to change the font on .logo, and it will show up for both sections:
Suggested change
| font-family: 'Berkshire Swash', cursive; | |
| font-family: inherit; |
| .box { | ||
| padding: 3em; | ||
| position: relative; | ||
| display: grid; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Personal Portfolio Site
Congratulations! You're submitting your assignment!
Comprehension Questions