forked from AdaGold/group-fansite
-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hang - Lions #103
Open
hangmtran
wants to merge
3
commits into
Ada-C18:master
Choose a base branch
from
hangmtran:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Hang - Lions #103
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,53 @@ | ||
<!DOCTYPE html> | ||
<html lang="en"> | ||
<head> | ||
<meta charset="UTF-8"> | ||
<meta http-equiv="X-UA-Compatible" content="IE=edge"> | ||
<meta name="viewport" content="width=device-width, initial-scale=1.0"> | ||
<title>Document</title> | ||
<meta charset="UTF-8"> | ||
<meta http-equiv="X-UA-Compatible" content="IE=edge"> | ||
<title>Home Page</title> | ||
<link rel = "stylesheet" href = "../styles/index.css"> | ||
</head> | ||
|
||
<body> | ||
|
||
<header> | ||
<h1>Hang Tran</h1> | ||
<h2> Software Developer</h2> | ||
</header> | ||
|
||
<nav class = "navbar"> | ||
<a href = "about.html">ABOUT ME</a> | ||
<a href = portfolio.html > PORTFOLIO</a> | ||
</nav> | ||
|
||
<main> | ||
<h3> Specializations</h3> | ||
<ul> | ||
<li> | ||
Python | ||
</li> | ||
<li> | ||
Flask | ||
</li> | ||
<li> | ||
SQL | ||
</li> | ||
<li> | ||
HTMl | ||
</li> | ||
<li> | ||
CSS | ||
</li> | ||
<li> | ||
Javascript | ||
</li> | ||
</ul> | ||
</main> | ||
|
||
<footer class = container> | ||
<h4>connect with me</h4> | ||
<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/4.7.0/css/font-awesome.min.css"> | ||
<a href="https://www.instagram.com/hang_m_tran/" class="fa fa-instagram"></a> | ||
<a href="https://www.linkedin.com/in/hang-m-tran/" class="fa fa-linkedin"></a> | ||
<a href="https://github.com/hangmtran" class="fa fa-github"></a> | ||
</footer> | ||
</body> | ||
</html> | ||
</html> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,113 @@ | ||
.hero { | ||
display: flex; | ||
align-items: center; | ||
justify-content: center; | ||
gap: 2.5rem; | ||
max-width: 68.75rem; | ||
margin: auto; | ||
} | ||
.hero img { | ||
height: 25em; | ||
width: 25rem; | ||
} | ||
|
||
.bio { | ||
width: 25rem; | ||
padding: 0.625rem; | ||
border-radius: 6px; | ||
box-shadow: 0px 4px 15px 4px var(--primary-shadow); | ||
} | ||
|
||
.bio h2 { | ||
margin-bottom: var(--bottom-margin); | ||
} | ||
|
||
.bio p { | ||
line-height: var(--line-height); | ||
padding: 0.3rem 0; | ||
} | ||
|
||
nav { | ||
position: sticky; | ||
top: 0; | ||
left: 0; | ||
z-index: 1; | ||
display: flex; | ||
align-items: center; | ||
justify-content: space-evenly; | ||
padding: .5rem 1rem; | ||
background-color: var(--bg-color); | ||
box-shadow: 0 3px 5px rgba(0, 0, 0, 0.1); | ||
} | ||
|
||
.navbar a { | ||
color: black; | ||
padding: 14px 20px; | ||
text-decoration: none; | ||
display: inline-block; | ||
|
||
} | ||
|
||
.navbar a:hover { | ||
color: #0000; | ||
background: | ||
linear-gradient(45deg, white, 50%,#000 0) | ||
var(--_p,100%)/200% no-repeat; | ||
-webkit-background-clip: text; | ||
background-clip: text; | ||
transition: .5s; | ||
--_p: 0%; | ||
} | ||
|
||
|
||
|
||
.fa { | ||
padding: 15px; | ||
font-size: 10px; | ||
width: 7.5px; | ||
height: 7.5px; | ||
text-align: center; | ||
text-decoration: none; | ||
border-radius: 50%; | ||
} | ||
|
||
|
||
.fa:hover { | ||
opacity: 0.7; | ||
} | ||
|
||
|
||
|
||
.fa-linkedin { | ||
background: black; | ||
color: white; | ||
} | ||
|
||
|
||
.fa-instagram { | ||
background: black; | ||
color: white; | ||
} | ||
|
||
.fa-github { | ||
background: black; | ||
color:white | ||
} | ||
Comment on lines
+81
to
+95
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since these all have the same property, you can do
or give all of these elements the same class name instead of three separate ones. |
||
|
||
|
||
.likes { | ||
display: flex; | ||
justify-content: space-evenly; | ||
|
||
|
||
} | ||
|
||
footer { | ||
text-align: center; | ||
} | ||
|
||
|
||
|
||
|
||
|
||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be great if the alt text for the images were more descriptive. For someone with low vision/blindness, they depend on screen readers to tell them what the picture is. For example, this picture will just be called "cooking", which doesn't capture the beautiful dish you've created.