completed project #116
completed project #116
Conversation
| </header> | ||
| <main class="intro"> | ||
| <div class="pp-col"> | ||
| <img class="pp" alt="portfolio photo" src="/images/tan_circle.JPG"> |
There was a problem hiding this comment.
Careful with your file paths! The /images/tan_circle.JPG path does not actually work because it is an incorrect absolute path. Starting a path with a slash (/) will start the file search at the root directory of your entire file system (not your project).
To correct this, we can use a relative path instead. This will provide directions to the target file based on the current file's location.
In code this looks like: ../images/tan_circle.JPG. The two dots at the beginning signal to start searching in the parent directory of the current directory.
Here is a great resource on absolute vs relative paths: https://www.geeksforgeeks.org/absolute-relative-pathnames-unix/
| <body> | ||
| <header> | ||
| <h1 class="header-name">Lex Miller</h1> | ||
| <input type="checkbox" id="nav-toggle" class="nav-toggle"> |
| </div> | ||
| </main> | ||
| <footer class="footer-content"> | ||
| <ul class="socials"> |
There was a problem hiding this comment.
I would recommend using a different tag here. The <ul> and <ol> tags should only be used if you're also using the <li> tag to construct a list.
Since you aren't using any <li> tags, I would recommend either switching this to a <div> or dropping this tag and moving the class assignment up to the <footer> tag.
This <ul>tag is also missing a closing tag. Make sure to run your html through the HTML Validator to catch bugs like this. https://validator.w3.org/
| <span></span> | ||
| </label> | ||
| </header> | ||
| <main class="about-me"> |
| <main class="contact-box"> | ||
| <h1 class="contact-header">Want to work together or have any questions?</h1> | ||
| <h1 class="contact-header2">Let's get in touch</h1> | ||
| <form class="form"> |
There was a problem hiding this comment.
Oooh! Super cool that you implemented a form! 👏🏾
| <div class="project-row"> | ||
| <div class="project-column"> | ||
| <div class="project-content"> | ||
| <img src="/images/viewingparty.png" alt="movie icon" class="project-icon" style="width:100"> |
There was a problem hiding this comment.
Good job having alt text for all your images! Make sure to include a unit of measure when specifying sizes (width is set to just 100).
| padding: 14px 50px; | ||
| text-align: center; | ||
| text-decoration: none; | ||
| display: center; |
There was a problem hiding this comment.
Careful! center isn't a valid value for the display property.
Personal Portfolio Site
Congratulations! You're submitting your assignment!
Comprehension Questions
A: A few issues that I had to resolve.
Why is it important to consider and use semantic HTML? |
A: It allows for better readability and for better understanding from the more descriptive tags.
How did you decide to structure your CSS? |
A: In order of how the pages lineup in my navigation.
What was the most challenging piece of this assignment? |
A: Trying to align the different items so they didn't look wonky.
Describe one area that you gained more clarity on when completing this assignment |
A: The importance of tags and what a difference it makes to be specific in your class names.
Optional |
Did you deploy to GitHub Pages? If so, what is the URL to your website? |
A: Not yet, but I plan to.