Tigers-Samiya-Chatlog #126
Conversation
…t two tests although the app is working.
There was a problem hiding this comment.
YELLOW! Overall this is a really good start, Samiya! The one glaring issue that keeps this from being a green is that you don't ever modify the messages list. You can toggle the heart front end, and you have found a workaround to make it count the number of likes. However, the actual information itself is never changed on the message's end.
| setLikeCount(likesCount-1) | ||
|
|
||
| } | ||
| } |
There was a problem hiding this comment.
This is a good start. However, your program is only changing the state of the likesCount and doesn't ever address the chatMessages. When you change the buttons, the likes will change visually, but each message's backend data will remain unchanged.
| </header> | ||
| <main> | ||
| {/* Wave 01: Render one ChatEntry component | ||
| <ChatLog entries={chatMessages}updateLikes={updateLikes} |
There was a problem hiding this comment.
Well done passing parameters via props!
| setLikeButton('🤍') | ||
| props.updateLikes(false) | ||
| } | ||
| } |
There was a problem hiding this comment.
Here is where you could have used the state that you pass in to handle what your output is. For example, if we had a props parameter called "isLiked," we could have used that in a simple ternary operator to spit out either the liked heart or the unliked heart.
| body:PropTypes.string.isRequired, | ||
| timeStamp:PropTypes.string.isRequired, | ||
| likes:PropTypes.bool.isRequired, | ||
|
|
||
| }; |
| <p className="entry-time"> | ||
| <TimeStamp time={props.timeStamp}/> | ||
| </p> | ||
| <button className="like" onClick={clickedToggle}>{likeButton}</button> |
There was a problem hiding this comment.
emember that we have passed down a function that is supposed to handle this for us. If we are having to rewrite this function, we aren't effectively lifting state up.
|
|
||
| ); | ||
| }; | ||
|
|
There was a problem hiding this comment.
Missing our proptypes! Other than that, this component is well-written!
My vs code was not working with the tests so i had to alter them to be single quotes. I didn't really know what to do so changed the test bc VS code was not happy!