AbbyG A19 Group Fansite #45
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ameerrah9
reviewed
Jun 10, 2023
ameerrah9
reviewed
Jun 10, 2023
Comment on lines
+11
to
+21
| <header> | ||
| <h1>FIN FACTS</h1> | ||
| </header> | ||
| <nav> | ||
| <a href="facts.html">Fin Facts</a> | ||
| <a href="index.html">Home</a> | ||
| <a href="gallery.html"><em>Gill</em>ary</a> | ||
| </nav> | ||
| <section class="Facts-Intro"> | ||
| <p>Sharks. The dog of the sea, the toothy terror, the gruesome gill monster. So many titles |
There was a problem hiding this comment.
It's a little subjective, but in this layout I might consider the header, nav and the section as part of the significant content of the page and place it inside a main tag.
ameerrah9
reviewed
Jun 10, 2023
| </ul> | ||
| </section> | ||
| <footer></footer> |
There was a problem hiding this comment.
Since this element is empty, we should remove it.
ameerrah9
reviewed
Jun 10, 2023
Comment on lines
+17
to
+25
| /> | ||
| <img | ||
| src= "../assets/Mauricio-Hoyos-5.jpg" | ||
| alt="shark 2" | ||
| /> | ||
| <img | ||
| src= "../assets/lemon-sharks-1.jpg.avif" | ||
| alt = "shark 3" |
There was a problem hiding this comment.
Really nice semantic HTML across the page!
ameerrah9
reviewed
Jun 10, 2023
Comment on lines
+27
to
+36
| src= "../assets/_20230323_on_whale_sharks.jpg" | ||
| alt = "shark 4" | ||
| /> | ||
| <img | ||
| src= "../assets/istockphoto-454433897-612x612.jpg" | ||
| alt = "shark 5" | ||
| /> | ||
| <img | ||
| src= "../assets/sharks-orig.jpg" |
There was a problem hiding this comment.
Some indentation is 2-spaces and some is 4-spaces, to make things easy to read and reduce possible confusion, we should pick one and be consistent across the page.
ameerrah9
reviewed
Jun 10, 2023
Comment on lines
+18
to
+24
| .Facts-Intro{ | ||
| display: flex; | ||
| flex-direction: column; | ||
| flex-wrap: wrap; | ||
| } | ||
|
|
||
| .Bullted-Facts{ |
There was a problem hiding this comment.
It's a little subjective, Class names are typically lower-cased
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.