forked from AdaGold/task-list
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADDING O-Auth to TaskListRails #83
Open
Trishthedish
wants to merge
29
commits into
Ada-C6:master
Choose a base branch
from
Trishthedish:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reate, and self.alltasks
…. However, it's taking users to a different page. About to make several changes and want to save working part.
…. I suspect that my logic is messed up.
…tempting to make edit work.
… data into the old hash values.
…in a checkbox. Our ERD hwk last night leads me to believe I could accomplish this more efficiently
… displays a checkmark when its completed.
…le. More styling to come.
…gged in' no log out button and not rendering avatar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/AdaGold/standalone-exercises/blob/master/tasklistrails-oauth.md
Accomplished Phase 1 and will continue to work on Phase 2 and 3 over the weekend.
@Hamled
Phase 1: Setting up OAuthFollowing the steps in the Textbook curriculum, add OAuth to your TaskListRails Application and enable a user to log in from the homepage.
Requirements:
Have a button on the home page for the user to log inThe log in button shall turn in to a log out button when the user is logged inAll other requirements from in-class notes apply:Managed via session
SessionsController
User model
Phase 2: User Authorization
Requirements:
Ensure that users who are not authenticated see a welcome message and a link to authenticate. No other pages should be viewable by the guest user.
Ensure that Users who are authenticated see the normal Tasklist page.
Build Automated Tests on the User Model.
Phase 3: Modifying The Task Model & Controller
Requirements:
Modify the Task Model to create a relation to the User Model. A User should have many tasks and each Task should belong to a User.
Modify the Task Controller index and show actions so that a user only sees tasks that belong to them.
Modify the Task Controller's edit and update method to ensure that the user cannot edit a task that does not belong to them.
Modify the new and create actions for the task controller so that the new task created will belong to the current user.
Ensure that unauthenticated users cannot create tasks and are redirected to login.