forked from AdaGold/tic-tac-toe
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WAVE 1 Complete: #5
Open
Trishthedish
wants to merge
50
commits into
Ada-C6:master
Choose a base branch
from
Trishthedish:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
constructor function for Game, 5 tests passing
tests for helloworld and incrementTurn; increment turn fx GREAT TEST DRIVEN DEVELOPMENT!
…o built function. Passing tests.
Used TDD to build tests for newly christened checkOccupied(). And als…
Added tests for play function. added logic for play function.
great job!
…lso added instance vars for magic square implementation
Magic square implementation
Added final diagonal check in tic-tac-toe functions.
…en and sipalyed instead of just returning board.
… play after someone has already won. Not dry, but quite sturdy\!
…ing models and views
…odel but outside of intialize.
… they will not pass yet. Able to succesfully play a game of tic-tac-toe in repl. Game behaves as expected.
All looks as it should. Moving on to next feature. Functionality within browser.
… grabing players names.
…to take out use o ftmplates
…t I'm unable to get any of my click events to work.
…oing to branch off and play with another technique.
…ly because of location of where I'd put my board
…as able to change one thing in one place to make X and O be emoji's
Making views
…ut doesn't behave in the way I would like.
…ered a new error in regards to determining winner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For: @PilgrimMemoirs && @CheezItMan
TRELLO BOARD
User Stories:
Specify up to two player names✅Get the current outcome of the game (X win, O win, tie, or undecided) ✅
(OPTIONAL) View a printed version of the current game board for debugging purposes ✅
Making this one happen was hard but it was final logic we put into place.
FROM: @Trishthedish && @laurenfb
Notes: We practiced some mad TDD skills on this project. We can proudly say we wrote each test prior to writing any code. 🎯⚡️🎉🔬
Played around with a whole new concept of magic square: