Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README to refer to a prior version of joinmarket #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sanket1729
Copy link

The current build fails with the following error: I don't think this project is actively maintained so I just added a checkout to where I know it works.

  File "rangeproof.py", line 291, in <module>
    run_test_rangeproof(value, rangebits)
  File "rangeproof.py", line 257, in run_test_rangeproof
    rp.generate_proof(proofval)
  File "rangeproof.py", line 57, in generate_proof
    pc = PC(encode(self.value, 256, minlen=32), blinding=self.gamma)
  File "/home/sanket1729/bulletproofs-poc/vectorpedersen.py", line 18, in __init__
    self.h = getNUMS(255).serialize() if not h else h
AttributeError: PublicKey instance has no attribute 'serialize'

The current build fails with the following error: I don't think this project is actively maintained so I just added a dependancy to a point where I know it works.

  File "rangeproof.py", line 291, in <module>
    run_test_rangeproof(value, rangebits)
  File "rangeproof.py", line 257, in run_test_rangeproof
    rp.generate_proof(proofval)
  File "rangeproof.py", line 57, in generate_proof
    pc = PC(encode(self.value, 256, minlen=32), blinding=self.gamma)
  File "/home/sanket1729/bulletproofs-poc/vectorpedersen.py", line 18, in __init__
    self.h = getNUMS(255).serialize() if not h else h
AttributeError: PublicKey instance has no attribute 'serialize'
@AdamISZ
Copy link
Owner

AdamISZ commented Dec 24, 2018

Indeed, this is not maintained; I listened to someone's advice that it'd be better not to have 'test' code out that people might incorrectly treat as actually usable, hence I removed the backend bitcoin functions and just left it.

Thanks for the attention though; I guess that, yes, this PR would be a way to try to run it, if you want to do so to help you figure out some details of what's going on in the bulletproofs range proof setup. No guarantees that this is actually functionally correct, bear that in mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants