Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use duality serializers for EditorUserData #860

Closed
wants to merge 8 commits into from
Closed

Use duality serializers for EditorUserData #860

wants to merge 8 commits into from

Conversation

Barsonax
Copy link
Member

@Barsonax Barsonax commented Jul 3, 2020

Changes:

  • Added a new way to save editoruserdata using duality serializers. Just serialize and deserialize models instead of XElements
  • Old system still works, it gets stored in a string field in PluginSettings. This prevents us from having to rewrite everything that uses this at the same time. Default settings have moved to their respective projects though with the use of EditorPlugin.GetDefaultUserData.
  • Dockpanel xml is stored in a separate string field on the DualityEditorUserData class

Issues:

  • Camview editor plugin has not been converted to the new api yet so for now keeping both systems intact. Refactorings where done in separate commits to make them easier to review or even split into a separate PR.

TODO

  • xml comments

@Barsonax Barsonax linked an issue Jul 3, 2020 that may be closed by this pull request
@Barsonax
Copy link
Member Author

rebase on master after #856 has been merged and then update it with the new changes introduced in that PR

@ilexp
Copy link
Member

ilexp commented Jul 18, 2020

Superseded by #865

@Barsonax Please document the relation of duplicate PRs / issues when closing them - makes it a lot easier to read when tracing back progress later on 🙂

@Barsonax
Copy link
Member Author

In case anyone in the future reads this. This PR was closed as I splitted up the changes into multiple PR's to make reviewing easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Refactor/rethink how duality handles settings
2 participants