Fix filter_map_tabs

Adanos020 · Mar 6, 2024 · 20f8e25 · 20f8e25
1 parent 1a5036c
commit 20f8e25
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,10 @@
 # egui_dock changelog
 
+## 0.11.3 - 2024-03-06
+
+### Fixed
+- `filter_map_tabs` sometimes deleting nodes when it shouldn't.
+
 ## 0.11.2 - 2024-02-16
 
 ### Fixed

diff --git a/src/dock_state/tree/mod.rs b/src/dock_state/tree/mod.rs
@@ -750,11 +750,11 @@ impl<Tab> Tree<Tab> {
             .iter()
             .enumerate()
             .map(|(index, node)| {
-                let node = node.filter_map_tabs(function.clone());
-                if node.is_empty() {
+                let filtered_node = node.filter_map_tabs(function.clone());
+                if filtered_node.is_empty() && !node.is_empty() {
                     emptied_nodes.insert(NodeIndex(index));
                 }
-                node
+                filtered_node
             })
             .collect();
         let mut new_tree = Tree {