Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #198282 foxford.ru #198309

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Fix #198282 foxford.ru #198309

wants to merge 9 commits into from

Conversation

rakleed
Copy link
Contributor

@rakleed rakleed commented Feb 10, 2025

Creating the pull request

Please include a summary of the change and which issue is fixed
If the related issue does not exist in our repository, please create it before making pull request
It is highly recommended to use our Web Reporting Tool instead of creating an issue on GitHub directly
Please note, that we verify every pull request manually, so it may take time to apply it

Prerequisites

To avoid invalid pull requests, please check and confirm following terms

  • This is not an ad/bug report;
  • My code follows the guidelines and syntax of this project;
  • I have performed a self-review of my own changes;
  • My changes do not break web sites, apps and files structure.

What problem does the pull request fix?

If the problem does not fall under any category that is listed here, please write a comment below in corresponding section

  • Missed ads or ad leftovers;
  • Website or app doesn't work properly;
  • AdGuard gets detected on a website;
  • Missed analytics or tracker;
  • Social media buttons — share, like, tweet, etc;
  • Annoyances — pop-ups, cookie warnings, etc;
  • Filters maintenance.

What issue is being fixed?

Enter the issue address

Closes #198282

Add your comment and screenshots

If possible, a screenshot of a page or application should not be cropped too much. Otherwise, it is not always clear where the element is located

  1. DO NOT upload screenshots with sexually explicit material on GitHub directly.
    Instead, upload it to a third-party image hosting and post the link to it without preview (!) here.
    Also, mention if the link leads to NSFW content;

  2. Add screenshots of the problem. You can drag and drop images or paste them from clipboard

    Use <details> </details> tag to hide screenshots under the spoiler;

  3. Describe the issue in detail until it is absolutely clear from the screenshot what the problem is

    You can also indicate any other information that you think the developers should know.

Warning: Please remove personal information before uploading screenshots!

  1. Your comment
  1. Screenshots
Screenshot 1:
Screenshot N:

Terms

  • By submitting this issue, I agree that pull request does not contain private info and all conditions are met

@rakleed rakleed mentioned this pull request Feb 10, 2025
Copy link
Member

@Alex-302 Alex-302 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zloyden @Sergey-Lyapin гляньте у себя на мобилах, всё ли в порядке. Меня не пускает.

@@ -159,6 +159,9 @@ www.kinopoisk.ru##div[class^="trailer-promo"]
!
! SECTION: Self-promo - Regular rules
!
foxford.ru##a[href^="https://programming-chatbot.foxford.ru/?erid="]
foxford.ru##div[class*="ContentContainer"] > div > div:has( > div > div > .slick-slider > .slick-list > .slick-track > .slick-slide > div > div > a[href="/dashboard/promos?block=coupons"])
foxford.ru##div[class*="ContentContainer"] > div:has( > div > div > a[href="/onboarding?chat=1"][class*="fox-Anchor"])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
foxford.ru##div[class*="ContentContainer"] > div:has( > div > div > a[href="/onboarding?chat=1"][class*="fox-Anchor"])

блокирует то, что не раздражает.

Copy link
Contributor Author

@rakleed rakleed Feb 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

На мобильном устройстве надо 2-3 экрана пролистать, чтобы дойти до следующего блока. Всё равно убрать это правило?

@@ -159,6 +159,9 @@ www.kinopoisk.ru##div[class^="trailer-promo"]
!
! SECTION: Self-promo - Regular rules
!
foxford.ru##a[href^="https://programming-chatbot.foxford.ru/?erid="]
foxford.ru##div[class*="ContentContainer"] > div > div:has( > div > div > .slick-slider > .slick-list > .slick-track > .slick-slide > div > div > a[href="/dashboard/promos?block=coupons"])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
foxford.ru##div[class*="ContentContainer"] > div > div:has( > div > div > .slick-slider > .slick-list > .slick-track > .slick-slide > div > div > a[href="/dashboard/promos?block=coupons"])
foxford.ru##div[class*="ContentContainer"] > div > div:has( > div > div > .slick-slider > .slick-list > .slick-track > .slick-slide > div > div > a[href="/dashboard/promos?block=coupons"])

это баннер моб. приложения.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Там также ещё про какие-то купоны идёт речь, поэтому решил добавить в self-promo:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

foxford.ru
4 participants