Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrupted Icon Overlay missing #433

Closed
Nercus opened this issue Feb 1, 2020 · 2 comments · May be fixed by #445
Closed

Corrupted Icon Overlay missing #433

Nercus opened this issue Feb 1, 2020 · 2 comments · May be fixed by #445

Comments

@Nercus
Copy link

Nercus commented Feb 1, 2020 •
edited
Loading

Describe the bug

There is no icon overlay for corrupted gear.

Do you have an error log of what happened?
no error log

To Reproduce

Steps to reproduce the behavior:

  1. Open Bag
  2. Icon Missing

Screenshots

Unbenannt

Did you try having Adibags as the only enabled addon and everything else disabled?
yes

Are you on World of Warcraft Classic or Retail?
Retail
@Nercus Nercus closed this as completed Feb 6, 2020
@Nercus Nercus reopened this Feb 6, 2020
@Nercus Nercus closed this as completed Feb 6, 2020
@shawngmc
Copy link

Looking at a framestack, in the regular bags a corrupted item has another layer, IconOverlay.
image

Any idea if this layer could be added to Adibags?

@shawngmc
Copy link

shawngmc commented Apr 22, 2020 •
edited
Loading

This is controlled in FrameXML\ItemButtonTemplate.lua around line 154:

image

Interestingly enough, this also controls the Azerite Empowered icon overlay. I'm not sure what that frame is off the top of my head though.

I'm not a Lua expert, but I'm a software engineer and may see if I can make a patch to submit. :)

@shawngmc shawngmc mentioned this issue Apr 22, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding IconOverlay Support
2 participants
@shawngmc @Nercus