Adding IconOverlay Support

[shawngmc]

What does this PR do?

Fixes #433 - the lack of the corrupted item overlay (eyeball) and Azerite item overlay (4 corner crystals).

Where should the reviewer start?

Have a corrupted gear piece and an azerite gear piece in bags.

How should this be manually tested?

• Open bag
• Verify corrupted gear pieces have eyeball in corner
• Verify azerite gear pieces have crystals in corners
• Verify other items display properly

Documents

Screenshots (if appropriate)

Before:

After:

Note: Check marks are from Can I Mog It and can be safely ignored.

[clmcgrath]

would this fix pawn icons as well ? i totally vote for this if it fixes this

[Meivyn]

I would suggest using this instead since this would be future-proof, and also adds support for IconOverlay2:

function buttonProto:UpdateOverlay()
	local _, _, _, quality = GetContainerItemInfo(self.bag, self.slot)
	SetItemButtonOverlay(self, self.itemId or self.itemLink or 0, quality)
end

That would also require making sure it only loads on Retail, so putting the method call into a self.isRetail block.

[Meivyn]

@Cidan Would you mind me doing another PR for this? The author seems to be unavailable. This is understandable considering the long wait time we had with PRs due to the lack of maintainers.

[shawngmc]

Update: I completely misread the comments - just realized @Meivyn was offering to make a new PR with those changes. Let me know how I can help.

@Meivyn Sorry for the late reply - I didn't see from the email notification that you were a contributor and not just a commenter. I can try to help, but I'm also not sure how to test this now - I don't think Azerite or Corrupted gear still cover this.

Looking at ItemButtonTemplate.lua it looks like Conduit items get a special frame - when I get home, I can see if they do.

I'm also not a fluent Lua/WoW UI coder. :) I do more JS and Python these days.

If @Cidan can't, I can try to take a look at this tonight or tomorrow; I do have raid tonight and am starting a public push on fixing the broken Guild/Community member popup menu in the base Blizzard UI. :)

[Cidan]

I'm fine with whomever wants to take a look at this, by all means! Now that DF PTR is out, I'm going to spend the next month focusing on finishing the new layout design + ensuring nothing breaks for DF + reskinning the default view to fit with DF.

[shawngmc]

I've added #701 as a new PR (my original fork is gone, so pulling the latest change in would be messy).

[Meivyn]

Looking at ItemButtonTemplate.lua it looks like Conduit items get a special frame - when I get home, I can see if they do.

I am not sure what IconOverlay2 is used for, it seems to have something to do with conduits "border", but they're also still using IconOverlay for it. I didn't look into it really.

ensuring nothing breaks for DF

Base game UI breaks easily and Ace3 might be broken as well from what I saw, so good luck!

[Maatouk84]

Would be nice if Pawn works again 💯