Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Owner value in Subscriptions and SubscriptionsByTopic responses #287

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

chrisdaly3
Copy link
Collaborator

I added the Owner field for both the ListSubscriptions and ListSubscriptionsByTopic requests, as well as added tests to confirm the field is populated with the expected value in the response.


-> ListSubscriptions

image

-> ListSubscriptionsByTopic

image

Note - sorry it took so long to get to this one!! Luckily the changes were pretty straightforward, and the tests are passing smoothly. Let me know if you have any questions 👍

@Admiral-Piett
Copy link
Owner

This looks great to me, thanks for looking into it! I rebased it and re-ran the checks, if those pass I shall merge it!

@Admiral-Piett Admiral-Piett merged commit ba9b48a into master Jan 9, 2024
2 checks passed
@Admiral-Piett Admiral-Piett deleted the populate-owner branch January 9, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants