[aws-json] Migrate SQS SendMessageBatch #309
Conversation
| for _, sendEntry := range sendEntries { | ||
| msg := app.Message{MessageBody: []byte(sendEntry.MessageBody)} | ||
| if len(sendEntry.MessageAttributes) > 0 { | ||
| oldStyleMessageAttributes := convertToOldMessageAttributeValueStructure(sendEntry.MessageAttributes) |
There was a problem hiding this comment.
I'm using the conversion step as SendMessageV1
https://github.com/Admiral-Piett/goaws/pull/288/files#diff-2b6e3902e73e67c2bf76a6c2ee3f3cc4be55d19105a543cf7954186e99c1ef54R63
app/models/sqs.go
Outdated
| entryIndex, err1 := strconv.Atoi(keySegments[1]) | ||
| attributeIndex, err2 := strconv.Atoi(keySegments[3]) | ||
| if err1 != nil || err2 != nil { |
There was a problem hiding this comment.
The case the number of key segments will be 4 (index 0 to 3) like: Entries.1.MessageAttributes.1.Name
The case that the number will be under 3 like: Entries.1.MessageBody
There was a problem hiding this comment.
Ah I see. Could you make a note of why the 2 are there? There's no way I'm going to remember that the Message Attributes have extra layers to them.
|
Hi @Admiral-Piett, could you please review this? |
app/models/sqs.go
Outdated
| entryIndex, err1 := strconv.Atoi(keySegments[1]) | ||
| attributeIndex, err2 := strconv.Atoi(keySegments[3]) | ||
| if err1 != nil || err2 != nil { |
There was a problem hiding this comment.
Ah I see. Could you make a note of why the 2 are there? There's no way I'm going to remember that the Message Attributes have extra layers to them.
kojisaikiAtSony
force-pushed
the
feature-aws-json-send-message-batch
branch
from
6c1b4e7 to
c7aeb43
Compare
|
Ready to merge! |
| } | ||
|
|
||
| // From like a value(Entries.1.MessageAttributes.1.Name), get the entry index and the attribute index. | ||
| entryIndex, err1 := strconv.Atoi(keySegments[1]) |
There was a problem hiding this comment.
I'm sorry, can we have a comment that mentions the pattern you're parsing at this index, and then another one for the index below? This will be difficult to consume and remember in the long term and the documentation is poor at describing it.
It took me a while in searching to figure out what we were going for (no fault of yours!), and I'd like to avoid that 30 minute search down the road.
There was a problem hiding this comment.
Even just something like the below would be amazing. Thank you!
Both patterns below are supported here.
// strconv.Atoi(keySegments[1] - targets the index value in pattern: `Entries.1.MessageBody`
// strconv.Atoi(keySegments[3] - targets the index value in pattern: `Entries.1.MessageAttributes.1.Name`
fixes comment
kojisaikiAtSony
force-pushed
the
feature-aws-json-send-message-batch
branch
from
c7aeb43 to
0d467b2
Compare
|
@Admiral-Piett Updated! |
Admiral-Piett
merged commit 14290cd
into
Admiral-Piett:feature-aws-json
No description provided.