Feature/ad 156 #364
Merged
Feature/ad 156 #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eprecated code removed
…eprecated code removed
…eprecated code removed
pjaneta
reviewed
Mar 19, 2024
There was a problem hiding this comment.
Maybe we should consider null parameter handling?
| public class DefaultSubscriptionAdyenCheckoutApiService extends DefaultAdyenCheckoutApiService { | ||
|
|
||
| protected static final Logger LOG = LogManager.getLogger(DefaultSubscriptionAdyenCheckoutApiService.class); | ||
| private CartFacade cartFacade; |
There was a problem hiding this comment.
Please remove unused fields
| final PaymentsRequest paymentsRequest = new PaymentsRequest(); | ||
|
|
||
| final PaymentRequest paymentsRequest = new PaymentRequest(); | ||
| //Blik |
| public RecurringDetailsRequest createListRecurringDetailsRequest(final String merchantAccount, final String customerId) { | ||
| return new RecurringDetailsRequest().merchantAccount(merchantAccount).shopperReference(customerId).selectOneClickContract(); | ||
| return new RecurringDetailsRequest().merchantAccount(merchantAccount).shopperReference(customerId);//.setRecurring(new Recurring());//.selectOneClickContract(); |
| @@ -476,7 +392,7 @@ public TerminalAPIRequest createTerminalAPIRequest(final CartData cartData, Cust | |||
| saleToAcquirerData.setShopperReference(shopperReference); | |||
| saleToAcquirerData.setRecurringContract(recurringContract.getContract().toString()); | |||
| } | |||
| updateApplicationInfoEcom(saleToAcquirerData.getApplicationInfo()); | |||
| //updateApplicationInfoEcom(saleToAcquirerData.getApplicationInfo()); | |||
| address.setStreet("NA"); | ||
|
|
||
| // set the actual values if they are available | ||
| if (addressData.getTown() != null && !addressData.getTown().isEmpty()) { |
There was a problem hiding this comment.
wouldn't it be better to use StringUtils.isNotEmpty()?
| @@ -842,21 +691,19 @@ public void setOpenInvoiceData(PaymentsRequest paymentsRequest, CartData cartDat | |||
| invoiceLines.add(invoiceLine); | |||
| } | |||
|
|
|||
| paymentsRequest.setLineItems(invoiceLines); | |||
| // paymentsRequest.setLineItems(invoiceLines); | |||
…eprecated code removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tested scenarios
Fixed issue: