Use bound vars internally #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nadrieril
force-pushed
the
use-bound-vars-internally
branch
2 times, most recently
from
c4230ce to
a3a0149
Compare
Nadrieril
force-pushed
the
use-bound-vars-internally
branch
from
a3a0149 to
9cfdc97
Compare
Nadrieril
force-pushed
the
use-bound-vars-internally
branch
from
9cfdc97 to
548d3b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #492, I decided to use
Freevars for the type-level variables bound in the signature andBoundvariables for those bound in an inner binder. After trying to implement the next PR that requires some non-trivial binder handling, this turned out to be a pain.In this PR, I use
Boundvariables everywhere inside charon. I restore the "Freefor signature-bound vars" usage in a micro-pass done at the end.There is still one different with what was done before this PR:
ImplElem::Tycontains a bbinder that used to be refered to usingFreevariables ad now uses `Boundè variables to avoid substitution mistakes.