Fix breadcrumb template URL in Vue #257
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for agnostic-astro canceled.
|
|
@roblevintennis do you mind merging this in and posting a new release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Binding of URL for breadcrumb items is not using the correct Vue syntax. The result is that the links are always pointing to the constant string
{route.url}. Probably some copy/paste leftover from other code in JSX syntax.This can also be seen in the documentation examples at
https://www.agnosticui.com/docs/components/breadcrumbs.html#examples
Hovering any one of the links will show the broken text instead of the expected target.
Checklist:
Please delete options that are not relevant.
We realize above checklist is pretty intimidating, reach out with an at mention on your issue if you're interested in contributing but need some clarifications!