Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linting #64

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Add linting #64

wants to merge 7 commits into from

Conversation

timokoessler
Copy link
Member

No description provided.

@timokoessler timokoessler marked this pull request as ready for review January 27, 2025 09:17
.github/workflows/lint.yml Outdated Show resolved Hide resolved
match tokenizer.tokenize() {
Ok(tokens) => tokens, // Return the tokens if successful
Err(_e) => {
Vec::new() // Return empty vector if unsuccessfull.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use this place often to add a dbg!(_e) statement 😬

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed back and added a linter ignore comment.

Whitespace::MultiLineComment(_) => true,
_ => false,
};
let whitespace_is_comment = matches!(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

covered?

#[no_mangle]
pub extern "C" fn detect_sql_injection(
pub unsafe extern "C" fn detect_sql_injection(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

required?

@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 96.96970% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/sql_injection/have_comments_changed.rs 66.66% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

…nting

* 'main' of github.com:AikidoSec/zen-internals:
  Add comments
  Ignore ffi and wasm bindings module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants