misc: use re2 if configured #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhoffm-aiven
force-pushed
the
mhoffm-use-re2
branch
from
5f366e9 to
7a7111f
Compare
Signed-off-by: Michael Hoffmann <[email protected]>
mhoffm-aiven
force-pushed
the
mhoffm-use-re2
branch
from
7a7111f to
fd641c0
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #164 +/- ##
==========================================
- Coverage 63.13% 63.03% -0.10%
==========================================
Files 19 19
Lines 2083 2086 +3
==========================================
Hits 1315 1315
- Misses 768 771 +3
|
aiven-amartin
approved these changes
Feb 22, 2024
There was a problem hiding this comment.
LGTM, @mhoffm-aiven if you can update the description a bit with context, will hold on a second reviewer before merging. [SRE-8038]
aiven-amartin
approved these changes
Feb 27, 2024
exg
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it possible to use re2 as a non-backtracking engine to evaluate searches. We make it opt-in, configurable using environment since otherwise it would constitute a breaking change.