Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use otel in core metrics #1035

Merged

Conversation

jjaakola-aiven
Copy link
Contributor

About this change - What it does

References: #xxxxx

Why this way

@jjaakola-aiven jjaakola-aiven changed the base branch from main to jjaakola-aiven-fastapi February 3, 2025 12:12
@jjaakola-aiven jjaakola-aiven changed the title Jjaakola aiven use otel in core metrics feat: use otel in core metrics Feb 3, 2025
@jjaakola-aiven jjaakola-aiven force-pushed the jjaakola-aiven-use-otel-in-core-metrics branch from c3df4a0 to 117f635 Compare February 3, 2025 12:15
Copy link

github-actions bot commented Feb 3, 2025

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  src/karapace
  __main__.py 9, 22, 29, 41-71
  rapu.py
  statsd.py
  src/karapace/api
  container.py
  controller.py
  factory.py 18-23, 40, 47
  user.py
  src/karapace/api/routers
  compatibility.py 15
  config.py
  mode.py 15
  schemas.py 15
  subjects.py 16
  src/karapace/api/telemetry
  container.py
  metrics.py
  setup.py 38
  src/karapace/core
  auth.py
  auth_container.py
  metrics_container.py
  schema_reader.py
  schema_registry.py
  stats.py 62-65, 70, 73, 76-77, 80-88, 91
Project Total  

This report was generated by python-coverage-comment-action

@jjaakola-aiven jjaakola-aiven marked this pull request as ready for review February 11, 2025 09:35
@jjaakola-aiven jjaakola-aiven requested a review from a team as a code owner February 11, 2025 09:35
Copy link
Contributor

@nosahama nosahama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the implementation, really nice, also shows how the DI containers simplify things. It's nice that you added dedicated containers.
[nit]

  • since we now have 2 containers in the core package, maybe we want to further group the container modules (auth_container and metrics_container) under a single package.
  • maybe we need to document somewhere that the config tags are added to metric labels and issue tracking.
  • would be nice to see the actual calls in the tests for the stats client.
  • there were also some commented code.
  • we no longer needstatsd-exporter.
  • grafana dashboard is broken, as we now have _total added to the metric names and thankfully we've also now changed the name of the exception metric 😅 , I can fix the dashboard in another PR.

@nosahama nosahama merged commit 3c28958 into jjaakola-aiven-fastapi Feb 11, 2025
10 checks passed
@nosahama nosahama deleted the jjaakola-aiven-use-otel-in-core-metrics branch February 11, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants