Fixed parsing GCS updated datetime string because fromisoformat does …

…not parse the used variation in Python <=3.10
Aiven-Open · Nov 27, 2024 · 83e06c1 · 83e06c1
1 parent 865965b
commit 83e06c1
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/rohmu/object_storage/google.py b/rohmu/object_storage/google.py
@@ -442,7 +442,7 @@ def initial_op(domain: Any) -> HttpRequest:
                         if (size := item.get("size")) is not None:
                             value["size"] = int(size)
                         if (updated := item.get("updated")) is not None:
-                            value["last_modified"] = datetime.datetime.fromisoformat(updated)
+                            value["last_modified"] = datetime.datetime.strptime(updated, "%Y-%m-%dT%H:%M:%S.%f%z")
                         if (md5 := item.get("md5Hash")) is not None:
                             value["md5"] = base64_to_hex(md5)
                         yield IterKeyItem(type=KEY_TYPE_OBJECT, value=value)

diff --git a/test/object_storage/test_google.py b/test/object_storage/test_google.py
@@ -363,7 +363,7 @@ def test_object_listed_when_missing_md5hash_size_and_updated() -> None:
                 sample_item,
                 {"size": 100, **sample_item},
                 {"md5Hash": base64.encodebytes(b"Missing md5Hash!"), **sample_item},
-                {"updated": "2023-11-20T16:18:00+00:00", **sample_item},
+                {"updated": "2023-11-20T16:18:00.000Z", **sample_item},
             ]
         }