Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encryptor: add support for symmetric encryption #165

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

exg
Copy link
Contributor

@exg exg commented Dec 22, 2023

This change adds variants of the Encryptor and Decryptor classes that use symmetric encryption.

This change adds variants of the Encryptor and Decryptor classes that
use symmetric encryption.
@codecov-commenter
Copy link

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (e7d8d4a) 71.97% compared to head (3e3b1f9) 72.30%.

Files Patch % Lines
rohmu/encryptor.py 89.54% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #165      +/-   ##
==========================================
+ Coverage   71.97%   72.30%   +0.33%     
==========================================
  Files          35       35              
  Lines        3928     4015      +87     
==========================================
+ Hits         2827     2903      +76     
- Misses       1101     1112      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@rikonen rikonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Leaving open for other people to have a look.

For context, we need this for AR-479 (internal ticket) where we want to use (unique) AES keys directly without any intermediate RSA.

Copy link

@c-garcia c-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rikonen rikonen merged commit 01a15d1 into main Jan 2, 2024
8 checks passed
@rikonen rikonen deleted the exg-symmetric-encryptor branch January 2, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants