Fix Azure typing issues #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugant
approved these changes
Aug 19, 2024
| # The description of CopyProperties tells us copy_id should not be None unless status is also None | ||
| # The type checker cannot know this, but we still log a warning if this ever happens | ||
| self.log.warning( | ||
| "Pending copy operation from %r to %r was missing a copy_id, will not be aborted after timeout", |
There was a problem hiding this comment.
nit: "will not be aborted after timeout" -> "thus cannot be aborted"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this change - What it does
The latest version of the azure-storage-blob package seems to have introduced some typing issues (most likely via Azure/azure-sdk-for-python@cb47de5).
This PR solves this.
Resolves: #xxxxx
Why this way
The version of
azure-storage-blobis explicitly un-pinned in thepyproject.tomlfile, so it seems like a better option to address the typing issue rather than pin the package to an older version.I opted for a warning log line instead of an assertion as that would at least provide some insight into what is happening. Theoretically, we might get in this situation even though the docs say we won't.