Fix init order

AlbumenJ · Nov 13, 2024 · 9e4c85c · 9e4c85c
1 parent 7e4f8cf
commit 9e4c85c
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 11 deletions.
diff --git a/...ing-api/src/main/java/org/apache/dubbo/remoting/api/pu/AbstractPortUnificationServer.java b/...ing-api/src/main/java/org/apache/dubbo/remoting/api/pu/AbstractPortUnificationServer.java
@@ -33,7 +33,7 @@ public abstract class AbstractPortUnificationServer extends AbstractServer {
     /**
      * extension name -> activate WireProtocol
      */
-    private final Map<String, WireProtocol> protocols;
+    private volatile Map<String, WireProtocol> protocols;
 
     /*
     protocol name --> URL object
@@ -50,21 +50,29 @@ public abstract class AbstractPortUnificationServer extends AbstractServer {
 
     public AbstractPortUnificationServer(URL url, ChannelHandler handler) throws RemotingException {
         super(url, handler);
-        ExtensionLoader<WireProtocol> extensionLoader =
-                url.getOrDefaultFrameworkModel().getExtensionLoader(WireProtocol.class);
-        this.protocols = extensionLoader.getActivateExtension(url, new String[0]).stream()
-                .collect(Collectors.toConcurrentMap(extensionLoader::getExtensionName, Function.identity()));
     }
 
     public Map<String, WireProtocol> getProtocols() {
         return protocols;
     }
 
+    @Override
+    protected final void doOpen() {
+        ExtensionLoader<WireProtocol> extensionLoader =
+                getUrl().getOrDefaultFrameworkModel().getExtensionLoader(WireProtocol.class);
+        this.protocols = extensionLoader.getActivateExtension(getUrl(), new String[0]).stream()
+                .collect(Collectors.toConcurrentMap(extensionLoader::getExtensionName, Function.identity()));
+
+        doOpen0();
+    }
+
+    protected abstract void doOpen0();
+
     /*
-    This method registers URL object and corresponding channel handler to pu server.
-    In PuServerExchanger.bind, this method is called with ConcurrentHashMap.computeIfPresent to register messages to
-    this supportedUrls and supportedHandlers
-     */
+        This method registers URL object and corresponding channel handler to pu server.
+        In PuServerExchanger.bind, this method is called with ConcurrentHashMap.computeIfPresent to register messages to
+        this supportedUrls and supportedHandlers
+         */
     public void addSupportedProtocol(URL url, ChannelHandler handler) {
         this.supportedUrls.put(url.getProtocol(), url);
         this.supportedHandlers.put(url.getProtocol(), handler);

diff --git a/...y/src/main/java/org/apache/dubbo/remoting/transport/netty/NettyPortUnificationServer.java b/...y/src/main/java/org/apache/dubbo/remoting/transport/netty/NettyPortUnificationServer.java
@@ -90,7 +90,7 @@ public void bind() {
     }
 
     @Override
-    protected void doOpen() {
+    protected void doOpen0() {
         NettyHelper.setNettyLoggerFactory();
         ExecutorService boss = Executors.newCachedThreadPool(new NamedThreadFactory(EVENT_LOOP_BOSS_POOL_NAME, true));
         ExecutorService worker =

diff --git a/.../src/main/java/org/apache/dubbo/remoting/transport/netty4/NettyPortUnificationServer.java b/.../src/main/java/org/apache/dubbo/remoting/transport/netty4/NettyPortUnificationServer.java
@@ -105,7 +105,7 @@ public void bind() throws Throwable {
     }
 
     @Override
-    public void doOpen() throws Throwable {
+    public void doOpen0() {
         bootstrap = new ServerBootstrap();
 
         bossGroup = NettyEventLoopFactory.eventLoopGroup(1, EVENT_LOOP_BOSS_POOL_NAME);