Add Link button components #2655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
force-pushed
the
link-buttons
branch
from
8439c37 to
73b3d59
Compare
These handle all the linking, unlinking as well as value writing and reading that the both "Link" and "Unlink" buttons do in one place, instead of shattered all over the place.
This makes the form behave like every other form and makes it more accessible.
tvdeyen
force-pushed
the
link-buttons
branch
from
73b3d59 to
a31516a
Compare
They need to be updated after we changed the icon_button styles.
tvdeyen
force-pushed
the
link-buttons
branch
from
a31516a to
bf52b2d
Compare
Symbols should be used to `send` or `define_method`s.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Introduces to new components used to link and unlink ingredients (pictures, text, link)
This fixes a bug introduced with the recent changes to the icon buttons and Shoelace tooltips.
The current implementation was relying to heavy on external DOM manipulation and needed
a special HTML structure.
The new components are self contained and have a API that the link dialog can use to place
links.
Notable changes
This also adds submit capabilities to the link dialog forms, so that they can now be submitted by enter key as well.
Checklist