Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve transparent backgrounds for PNGs #2666

Merged
merged 1 commit into from
Dec 29, 2023
Merged

Preserve transparent backgrounds for PNGs #2666

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/models/alchemy/picture_variant.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ def encoded_image(image, options = {})
end

if options[:flatten]
encoding_options << "-background transparent" if render_format == "png"
encoding_options << "-flatten"
end

Expand Down
1 change: 1 addition & 0 deletions config/initializers/dragonfly.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

# Dragonfly 1.4.0 only allows `quality` as argument to `encode`
Dragonfly::ImageMagick::Processors::Encode::WHITELISTED_ARGS << "flatten"
Dragonfly::ImageMagick::Processors::Encode::WHITELISTED_ARGS << "background"

Rails.application.config.after_initialize do
Dragonfly.app(:alchemy_pictures).add_processor(:crop_resize, Alchemy::Dragonfly::Processors::CropResize.new)
Expand Down
Binary file added spec/fixtures/animated.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion spec/models/alchemy/picture_variant_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@
it "flattens the image." do
step = subject.steps[0]
expect(step.name).to eq(:encode)
expect(step.arguments).to eq(["png", "-flatten"])
expect(step.arguments).to eq(["png", "-background transparent -flatten"])
end

context "converted to webp" do
Expand Down