Use safe redirect paths in admin redirects #3129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
changed the title
This makes sure we only redirect internally in the /admin routing context and redirect to a given safe fallback location or the default admin route.
tvdeyen
force-pushed
the
safe-redirect-path
branch
from
e97046f to
6b064de
Compare
This makes sure all redirects we do in the admin via do_redirect_to uses a safe redirect url.
tvdeyen
force-pushed
the
safe-redirect-path
branch
from
6b064de to
7adefce
Compare
tvdeyen
added
backport-to-7.0-stable
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3129 +/- ##
=======================================
Coverage 96.58% 96.58%
=======================================
Files 236 236
Lines 6347 6360 +13
=======================================
+ Hits 6130 6143 +13
Misses 217 217 ☔ View full report in Codecov by Sentry. |
mamhoff
approved these changes
Jan 6, 2025
💔 Some backports could not be created
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
This makes sure all redirects we do in the admin via
do_redirect_touses a safe redirect url.Notable changes
Introduces
safe_redirect_pathmethod, that makes sure we only redirect internallyin the /admin routing context and redirect to a given safe fallback location or the
default admin route.
Checklist