Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding interview as new claim type #1396

Draft
wants to merge 3 commits into
base: stage
Choose a base branch
from
Draft

Conversation

LuizFNJ
Copy link
Collaborator

@LuizFNJ LuizFNJ commented Oct 10, 2024

Description

The goal of this PR is to implement the 'claim type' functionality for interviews. In this first commit, my objective is to replicate the existing debate mechanics, as I believe interview claims will have a similar structure. As I receive feedback, I plan to improve the code, further customize the interview claim, and fix both the bugs I've already identified and any that may arise.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Existing feature enhancement (non-breaking change which modifies existing functionality)

Testing

With the addition of new claims to the platform, it will be possible to test both their creation and editing.

Developer Checklist

General

  • Code is appropriately commented, particularly in hard-to-understand areas
  • Repository documentation has been updated (Readme.md) with additional steps required for a local environment setup.
  • No console.log or related logging is added.
  • No code is repeated/duplicated in violation of DRY. The exception to this is for new (MVP/Prototype) functionality where the abstraction layer may not be clear (comments should be added to explain the violation of DRY in these scenarios).
  • Documented with TSDoc all library and controller new functions

Frontend Changes

  • No new styling is added through CSS files (Unless it's a bugfix/hotfix)
  • All types are added correctly

Backend Changes

  • All endpoints are appropriately secured with Middleware authentication
  • All new endpoints have a interface schema defined

Tests

  • All existing unit and end to end tests pass across all services
  • Unit and end to end tests have been added to ensure backend APIs behave as expected

Merge Request Review Checklist

  • An issue is linked to this PR and these changes meet the requirements outlined in the linked issue(s)
  • High risk and core workflows have been tested and verified in a local environment.
  • Enhancements or opportunities to improve performance, stability, security or code readability have been noted and documented in JIRA issues if not being addressed.
  • Any dependent changes have been merged and published in downstream modules
  • Changes to multiple services can be deployed in parallel and independently. If not, changes should be broken out into separate merge requests and deployed in order.

@LuizFNJ LuizFNJ changed the title adding-draft-claim-type-interview. adding-claim-type-interview. Oct 10, 2024
@LuizFNJ LuizFNJ marked this pull request as ready for review October 10, 2024 23:10
@LuizFNJ LuizFNJ requested a review from thesocialdev as a code owner October 10, 2024 23:10
@pepermao pepermao marked this pull request as draft October 14, 2024 11:41
@LuizFNJ LuizFNJ changed the title adding-claim-type-interview. adding claim type interview Oct 16, 2024
@LuizFNJ LuizFNJ changed the title adding claim type interview Adding interview as new claim type Oct 16, 2024
@LuizFNJ LuizFNJ force-pushed the add-interview-claim-type branch from c9a1ecd to 25afa39 Compare October 17, 2024 14:19
@thesocialdev
Copy link
Collaborator

This is getting good! We need now to start looking for the abstract components and reduce duplicated code.

@thesocialdev thesocialdev force-pushed the stage branch 6 times, most recently from 05f8912 to 864c35e Compare November 7, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants